Skip to content

Fixes #39684 - Scope Puppet autocomplete by taxonomy - #454

Open
jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/39684-puppet-autocomplete-taxonomies
Open

Fixes #39684 - Scope Puppet autocomplete by taxonomy#454
jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/39684-puppet-autocomplete-taxonomies

Conversation

@jakduch

@jakduch jakduch commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #39684 as a follow-up to foreman_puppet #450.

The custom Puppet assignment completer queried classes and config groups globally, bypassing the current organization and location scope of the host or host group being searched. Restrict its assignment subqueries to host and host group Puppet facets visible in the active taxonomies. Direct assignments, inherited host group assignments, and assignments through config groups remain available.

Testing

  • Ruby syntax checks pass for all changed files
  • git diff --check passes
  • Regression coverage verifies organization scoping for host completions and location scoping for host group completions
  • Coverage includes both Puppet class and config group values
  • Full Rails tests are left to CI

AI usage disclosure

Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an Assisted-By trailer.

Limit Puppet class and config group suggestions to assignments from hosts and host groups visible in the current organization and location. Cover both taxonomy dimensions and resource types.

Assisted-By: Codex 5.6 Sol High
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant