Add Puppet environment bulk actions - #443
Open
nadjaheitmann wants to merge 1 commit into
Open
Conversation
nadjaheitmann
marked this pull request as draft
May 20, 2026 07:50
nadjaheitmann
force-pushed
the
environment_bulk_action
branch
6 times, most recently
from
May 21, 2026 10:37
7b47350 to
b3a99a0
Compare
nadjaheitmann
force-pushed
the
environment_bulk_action
branch
9 times, most recently
from
July 17, 2026 10:29
6e4a70a to
a6a902f
Compare
nadjaheitmann
marked this pull request as ready for review
July 17, 2026 12:00
sbernhard
reviewed
Jul 20, 2026
|
|
||
| const handleError = response => { | ||
| handleModalClose(); | ||
| dispatch( |
Contributor
There was a problem hiding this comment.
is it possible to re-use https://github.com/theforeman/foreman/pull/11045/changes ?
Collaborator
Author
There was a problem hiding this comment.
Yeah, and also theforeman/foreman#11110 I guess
Collaborator
Author
There was a problem hiding this comment.
is it possible to re-use https://github.com/theforeman/foreman/pull/11045/changes ?
I have not yet added this part. We can do it as a follow-up and also change the other bulk action to use that error handling so that it is consistent for all actions of the plugin.
sbernhard
reviewed
Jul 20, 2026
sbernhard
reviewed
Jul 20, 2026
m-bucher
reviewed
Jul 24, 2026
Comment on lines
65
to
67
| p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/change_environment' | ||
| p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/change_puppet_proxy' | ||
| p.actions << 'foreman_puppet/api/v2/hosts_bulk_actions/remove_puppet_proxy' |
There was a problem hiding this comment.
These might need changing based on the result in the above comment.
m-bucher
reviewed
Jul 24, 2026
|
|
||
| def put_change_environment(params:, session: nil) | ||
| original_routes = @routes | ||
| @routes = ForemanPuppet::Engine.routes |
There was a problem hiding this comment.
This would also be obsolete, when api_routes is changed.
m-bucher
reviewed
Jul 24, 2026
Comment on lines
+20
to
+29
| inherited_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location]) | ||
| hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, | ||
| environment: inherited_environment, | ||
| organizations: [organization], | ||
| locations: [location]) | ||
| inherited_hosts = FactoryBot.create_list(:host, 2, :with_puppet_enc, | ||
| environment: inherited_environment, | ||
| hostgroup: hostgroup, | ||
| organization: organization, | ||
| location: location) |
There was a problem hiding this comment.
The test setup should not already fulfill the test-assertion.
Suggested change
| inherited_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location]) | |
| hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, | |
| environment: inherited_environment, | |
| organizations: [organization], | |
| locations: [location]) | |
| inherited_hosts = FactoryBot.create_list(:host, 2, :with_puppet_enc, | |
| environment: inherited_environment, | |
| hostgroup: hostgroup, | |
| organization: organization, | |
| location: location) | |
| inherited_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location]) | |
| host_environment = FactoryBot.create(:environment, organizations: [organization], locations: [location]) | |
| hostgroup = FactoryBot.create(:hostgroup, :with_puppet_enc, | |
| environment: inherited_environment, | |
| organizations: [organization], | |
| locations: [location]) | |
| inherited_hosts = FactoryBot.create_list(:host, 2, :with_puppet_enc, | |
| environment: host_environment, | |
| hostgroup: hostgroup, | |
| organization: organization, | |
| location: location) | |
| assert_not_equal host_environment, inherited_environment |
nadjaheitmann
force-pushed
the
environment_bulk_action
branch
3 times, most recently
from
August 25, 2026 13:27
44e2646 to
88f0454
Compare
Co-Authored-By: OpenAI Codex <codex@openai.com>
nadjaheitmann
force-pushed
the
environment_bulk_action
branch
from
August 25, 2026 13:30
88f0454 to
999e56b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: OpenAI Codex codex@openai.com