Skip to content

Fixes #39566 - add test_setup file that imports foremanJSTestSetup - #618

Merged
adamruzicka merged 1 commit into
theforeman:masterfrom
andreilakatos:fixes-39566-add-test-setup-file
Aug 13, 2026
Merged

Fixes #39566 - add test_setup file that imports foremanJSTestSetup#618
adamruzicka merged 1 commit into
theforeman:masterfrom
andreilakatos:fixes-39566-add-test-setup-file

Conversation

@andreilakatos

Copy link
Copy Markdown
Contributor

Fixes #39566 - add test_setup file that imports foremanJSTestSetup

@ofedoren

ofedoren commented Aug 4, 2026

Copy link
Copy Markdown
Member

Not against that, but wonder: why do we need that exactly? It's not mentioned neither in RM nor Jira ticket...

@andreilakatos

Copy link
Copy Markdown
Contributor Author

Not against that, but wonder: why do we need that exactly? It's not mentioned neither in RM nor Jira ticket...

This is the ticket explaining it:

https://redhat.atlassian.net/browse/SAT-48340
Foreman core has a test setup and plugins should reuse that instead of duplicating it. This aims to make it easier to maintain.

@ofedoren

ofedoren commented Aug 4, 2026

Copy link
Copy Markdown
Member

Thanks, @andreilakatos !

Ruby test failures are unrelated, but JS ones are :/

@andreilakatos
andreilakatos force-pushed the fixes-39566-add-test-setup-file branch from 5923b87 to 9bcedac Compare August 4, 2026 11:23
@ofedoren

ofedoren commented Aug 5, 2026

Copy link
Copy Markdown
Member

Apologies, I'm dumb (or just blind): all the JS failures should be fixed by #617 (linting, constants, etc), so we'd rather get that one in first, then rebase this one and merge if nothing's weird.

@andreilakatos

Copy link
Copy Markdown
Contributor Author

Apologies, I'm dumb (or just blind): all the JS failures should be fixed by #617 (linting, constants, etc), so we'd rather get that one in first, then rebase this one and merge if nothing's weird.

Happens to everyone, lol

@andreilakatos
andreilakatos force-pushed the fixes-39566-add-test-setup-file branch from 9bcedac to 13bc2a2 Compare August 13, 2026 08:52
@adamruzicka
adamruzicka merged commit 5b197ca into theforeman:master Aug 13, 2026
16 checks passed
@adamruzicka

Copy link
Copy Markdown
Contributor

Thank you @andreilakatos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants