Skip to content

Fixes #39196 - Render Puppet masterport setting - #11241

Open
jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39196
Open

Fixes #39196 - Render Puppet masterport setting#11241
jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39196

Conversation

@jakduch

@jakduch jakduch commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #39196

The puppet.conf snippet currently renders a custom Puppet server port as port, which is not the Puppet agent setting used to contact Puppet Server. Render the value as masterport while continuing to omit the default port.

Testing prerequisites:

  • None

Testing scenarios:

  • Set puppet_server_port to 4443 and render puppet.conf. Verify masterport = 4443 is present and port = 4443 is absent.
  • Set puppet_server_port to 8140 and verify masterport is omitted.

Verification:

  • Targeted renderer tests pass on Ruby 3.3 with PostgreSQL 13.
  • Full test:units passes: 5,648 tests and 14,085 assertions, with 0 failures and 0 errors.
  • RuboCop reports no offenses in the added test.

Use Puppet's canonical masterport setting when rendering a non-default server port. Add snippet rendering coverage for custom and default ports.

Assisted-By: Codex 5.6 Sol High
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant