Fixes #39196 - Render Puppet masterport setting - #11241
Open
jakduch wants to merge 1 commit into
Open
Conversation
Use Puppet's canonical masterport setting when rendering a non-default server port. Add snippet rendering coverage for custom and default ports. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39196
The puppet.conf snippet currently renders a custom Puppet server port as port, which is not the Puppet agent setting used to contact Puppet Server. Render the value as masterport while continuing to omit the default port.
Testing prerequisites:
Testing scenarios:
Verification: