Skip to content

Fixes #39745 - remove ForemanModal and its uses inside the repo - #11236

Merged
ofedoren merged 1 commit into
theforeman:developfrom
andreilakatos:fixes-39745-remove-foremanmodal
Sep 10, 2026
Merged

Fixes #39745 - remove ForemanModal and its uses inside the repo#11236
ofedoren merged 1 commit into
theforeman:developfrom
andreilakatos:fixes-39745-remove-foremanmodal

Conversation

@andreilakatos

@andreilakatos andreilakatos commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #39745 - remove ForemanModal and its uses inside the repo

Created https://redhat.atlassian.net/browse/SAT-50307, for the Katello change necessary after this PR is merged

Looks like Katello/katello#11857 needs to be merged so tests are passing

@github-actions github-actions Bot added the UI label Sep 9, 2026
@LadislavVasina1

LadislavVasina1 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

I found some mentions about ForemanModal in https://github.com/theforeman/foreman/blob/develop/developer_docs/state-management.asciidoc#other-react-contexts
Should we remove those mentions too?

@andreilakatos

andreilakatos commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

I found some mentions about ForemanModal in https://github.com/theforeman/foreman/blob/develop/developer_docs/state-management.asciidoc#other-react-contexts Should we remove those mentions too?

Good point, I'll do that

@andreilakatos
andreilakatos force-pushed the fixes-39745-remove-foremanmodal branch from fe34051 to 492cd5b Compare September 9, 2026 12:46
@github-actions github-actions Bot added the Docs label Sep 9, 2026
LadislavVasina1
LadislavVasina1 approved these changes Sep 9, 2026
View reviewed changes

@LadislavVasina1 LadislavVasina1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the changes and I don't see any other mentions about ForemanModal, ACK.

chris1984
chris1984 approved these changes Sep 9, 2026
View reviewed changes

@chris1984 chris1984 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged the katello pr, don't see any other references like @LadislavVasina1 said

@andreilakatos
andreilakatos force-pushed the fixes-39745-remove-foremanmodal branch from 492cd5b to 9793c96 Compare September 9, 2026 14:05
@ofedoren

ofedoren commented Sep 10, 2026

Copy link
Copy Markdown
Member

/packit build

ofedoren
ofedoren approved these changes Sep 10, 2026
View reviewed changes

@ofedoren ofedoren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andreilakatos, @chris1984 and @LadislavVasina1 !

@ofedoren
ofedoren merged commit 15c7b20 into theforeman:develop Sep 10, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofedoren ofedoren ofedoren approved these changes
+2 more reviewers
@chris1984 chris1984 chris1984 approved these changes
@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreilakatos @LadislavVasina1 @ofedoren @chris1984