Fix subtitle settings not being respected during playback#32
Merged
theepicsaxguy merged 1 commit intomainfrom Feb 23, 2026
Merged
Fix subtitle settings not being respected during playback#32theepicsaxguy merged 1 commit intomainfrom
theepicsaxguy merged 1 commit intomainfrom
Conversation
Owner
theepicsaxguy
commented
Feb 23, 2026
theepicsaxguy
commented
- Read show_subtitles and subtitle_mode from settings in player-render.js
- Add full text mode rendering that shows all sentences at once
- Hide subtitle container when show_subtitles is disabled
- Support both karaoke (word-by-word) and full text subtitle modes
- Read show_subtitles and subtitle_mode from settings in player-render.js - Add full text mode rendering that shows all sentences at once - Hide subtitle container when show_subtitles is disabled - Support both karaoke (word-by-word) and full text subtitle modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.