Merged
Conversation
- Add custom-instance.ts that auto-extracts .data from AxiosResponse - Update orval.config.mjs to use the custom mutator - Simplify api.ts to clean re-exports (no Proxy) - Add typed URL builder functions (chunkAudioUrl, fullEpisodeAudioUrl, sourceCoverUrl) - Add tsconfig.json for strict TypeScript type-checking - Add typecheck script (tsc --noEmit) to package.json - Regenerate client.ts with the new mutator Co-authored-by: theepicsaxguy <theepicsaxguy@users.noreply.github.com>
1. Invisible mobile overlay deadlock: Add base CSS for .sidebar-overlay with pointer-events:none when not .visible 2. SPA hash routing desync: Force re-route when clicking the same mobile nav tab, close open bottom sheets on nav tap 3. Touch event swallowing: Tighten swipe detection to require <40px vertical drift and 3:1 horizontal dominance ratio 4. XSS in dom.js: Rename setContent to setTrustedHTML with clear documentation, add eslint-disable comments for audited usages 5. Audio duration NaN race conditions: Replace all audio.duration truthy checks with isFinite(audio.duration) across player modules 6. Zombie event listeners: Add initialization guards to all init functions (initControls, initFullscreenPlayer, initSwipeGestures, initTouchGestures) to prevent duplicate listener registration 7. State mutation by reference: Add deepFreeze() to state.js set() so subscribers cannot mutate shared state objects Co-authored-by: theepicsaxguy <theepicsaxguy@users.noreply.github.com>
- Add no-restricted-syntax rule banning innerHTML assignment globally - Exempt dom.js where setTrustedHTML/fromHTML are the centralized wrappers - Migrate library.js, main.js, editor.js to use setTrustedHTML/fromHTML - Add isFinite to ESLint globals - ESLint passes cleanly with zero warnings Co-authored-by: theepicsaxguy <theepicsaxguy@users.noreply.github.com>
…ects - Add mobile-chrome (Pixel 5) and mobile-safari (iPhone 13) projects - Add overlay deadlock tests: verify no invisible overlays block taps - Add SPA hash routing tests: verify same-tab click resets view state - Add console error policy: fail on any TypeError/NaN/unhandled errors - Add memory leak regression: verify heap doesn't grow 10MB+ over 30 navs - Add state immutability smoke test: verify frozen objects reject mutation - Add audio race condition test: player controls safe without loaded audio - Add mobile UI integrity tests: nav, import form, settings on mobile Co-authored-by: theepicsaxguy <theepicsaxguy@users.noreply.github.com>
- Add 'typecheck' job: runs tsc --noEmit to validate Orval-generated client against frontend logic (catches stale API references) - Add typecheck to Docker build dependency chain - Update E2E job to run all 3 Playwright projects: chromium (Desktop Chrome), mobile-chrome (Pixel 5), mobile-safari (iPhone 13) - Pipeline now enforces: Python lint, JS lint (with innerHTML ban), TypeScript types, API client freshness, Docker build, and Desktop + Mobile E2E tests Co-authored-by: theepicsaxguy <theepicsaxguy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a fully automated API generation and validation pipeline, fixes 7 critical UI/UX bugs, and adds comprehensive E2E tests to prevent regressions.
This PR overhauls the frontend development process by automating API client generation, eliminating manual maintenance, and introducing strict CI validation. It addresses 7 critical, long-standing bugs including invisible mobile overlays, SPA hash desynchronization, accidental touch swipes, XSS vulnerabilities, audio duration race conditions, memory leaks from zombie event listeners, and state mutation by reference. The new pipeline ensures these issues are caught automatically before reaching production.