Add the raw_parser option to pass XML directly to the exporter #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly to the exporter
netsensei
reviewed
Feb 9, 2018
| @@ -90,7 +91,8 @@ sub add { | |||
| my $token = $self->access_token; | |||
| my $response; | |||
|
|
|||
| $response = $self->client->post($url, Content_Type => 'application/lido+xml', Authorization => sprintf('Bearer %s', $token), Content => $data); | |||
| my $enc_data = encode_utf8($data); | |||
There was a problem hiding this comment.
Why do you this here? What's the added benefit of doing an encode_utf8()?
There was a problem hiding this comment.
If $data contains non-ascii-characters, the client will fail.
netsensei
reviewed
Feb 9, 2018
| return $self->api->update($data->{'id'}, $data->{'_'}); | ||
|
|
||
| if ($self->store->raw_parser == 1) { | ||
| return $self->api->add($data->{'_metadata'}); |
There was a problem hiding this comment.
I don't think the Datahub API should make any assumptions about the datamodel of the incoming data. the _metadata construct is a typical ouptput of OAI. I think this would violate the open/closed principle.
Maybe a separate optional parser object could be injected here. Maybe not in the API implementation itself, but right before the data is passed of to this method.
There was a problem hiding this comment.
Agreed, should be part of the transformation (perhaps in a fix?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the raw_parser option to pass XML parsed by AOI::Parser::raw directly to the exporter. See this issue in Datahub-Factory.