Skip to content

Fix "pardon the interruption" popup block #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix "pardon the interruption" popup block #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2287e7f
Fix "pardon the interruption" popup block
thebaer Jun 7, 2019
b1815e7
Fix sticky header bar
thebaer Jul 23, 2019
3fdac45
Block popup again
thebaer Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

var makeReadable = function() {
// Un-position:fixed the top nav bar
var topNav = document.querySelector('.metabar.u-fixed');
var topNav = document.querySelector('.branch-journeys-top');
if (topNav) {
topNav.classList.remove('u-fixed');
topNav.parentNode.style.position = 'absolute';
}

// Remove the "Pardon the interruption" popup.
Expand All @@ -15,10 +15,10 @@ var makeReadable = function() {
// don't want to obliterate them too.
// FIXME: prevent this from breaking signup/login dialogs when the popup
// is removed (it works after changing pages).
var headings = document.evaluate("//h1[contains(., 'Pardon the interruption.')]", document, null, XPathResult.ANY_TYPE, null );
var headings = document.evaluate("//h4[contains(., 'one more story in your member preview this month')]", document, null, XPathResult.ANY_TYPE, null );
var thisHeading = headings.iterateNext();
if (thisHeading != null) {
var $overlay = thisHeading.parentNode.parentNode.parentNode.parentNode;
var $overlay = thisHeading.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode;
$overlay.parentNode.removeChild($overlay);
}

Expand Down