cmd: add --objstore.config-file flag #30
Open
+164
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxric
force-pushed
the
alex/obj_storage
branch
from
b6e7583 to
879eec7
Compare
|
Is this a duplicate of the work being done here? @MichaHoffmann / @verejoel was there ever an agreed pattern for using a configuration file over inline flags? We have made a change within our folk to support other cloud providers but this change would remove the need for that |
alxric
force-pushed
the
alex/obj_storage
branch
from
879eec7 to
8ff1fb2
Compare
cmd/convert.go
Outdated
| cmd.Flag("parquet.storage.s3.access_key", "access key for s3").Default("").Envar("PARQUET_STORAGE_S3_ACCESS_KEY").StringVar(&opts.s3AccessKey) | ||
| cmd.Flag("parquet.storage.s3.secret_key", "secret key for s3").Default("").Envar("PARQUET_STORAGE_S3_SECRET_KEY").StringVar(&opts.s3SecretKey) | ||
| cmd.Flag("parquet.storage.s3.insecure", "use http").Default("false").BoolVar(&opts.s3Insecure) | ||
| cmd.Flag("objstore-parquet.config-file", "YAML file that contains object store configuration for parquet storage. See format details: https://thanos.io/tip/thanos/storage.md/#configuration").StringVar(&opts.objStoreConfigFile) |
Collaborator
There was a problem hiding this comment.
parquet.objstore-config-file and similar in other places?
This to be more in line with how the other thanos components work, allowing you to specify the path to a yaml config file instead of passing the object storage config as individual parameters direcly. Signed-off-by: Alexander Rickardsson <[email protected]>
alxric
force-pushed
the
alex/obj_storage
branch
from
8ff1fb2 to
e10cef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to be more in line with how the other thanos components work, allowing you to specify the path to a yaml config file instead of passing the object storage config as individual parameters direcly.