Add trimmer for extra field in config yaml #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: milinddethe15 <[email protected]>
| filtered[key] = value | ||
| } | ||
| } | ||
| return yaml.Marshal(filtered) |
Contributor
There was a problem hiding this comment.
Isnt it kinda weird that we marshal it back to yaml just to parse it again?
Contributor
Author
There was a problem hiding this comment.
Hmm.. Lets keep this simple and handle hedging_config field only seperately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New function to trim extra fields from YAML config.
clientutil/trimconfig.go: Added a new functionTrimExtraFieldsthat removes any fields from the YAML configuration that are not explicitly allowed.Verification
clientutil/trimconfig_test.go: Added tests for theTrimExtraFieldsfunction to ensure it correctly filters out unwanted fields from the YAML configuration.