Do not depend on clusterDomain == cluster.local #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the default DNS domain of a Kubernetes cluster is 'cluster.local', it can be changed. Furthermore, container running in Kubernetes gets injected search domains in their /etc/resolv.conf of the following form: search <namespace>.svc.<cluster-domain> svc.<cluster-domain> <cluster-domain> This means a good way to be agnostic regarding the cluster DNS domain is to simply not specify it. The downside is that the number of DNS queries might increase, because the search domains are tried in order (which is why "<service>.<ns>" is better than "<service>.<ns>.svc"). Signed-off-by: Max Gautier <[email protected]>
Signed-off-by: Max Gautier <[email protected]>
|
I encountered the same issue related to the clustered domain that this PR addresses and created a simple patch to work around it: However, the approach in this PR looks much cleaner and more comprehensive than my quick fix, so I’d really like to see it merged. Thank you for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While the default DNS domain of a Kubernetes cluster is 'cluster.local',
it can be changed.
Furthermore, container running in Kubernetes gets injected search
domains in their /etc/resolv.conf of the following form:
search .svc. svc.
This means a good way to be agnostic regarding the cluster DNS domain is
to simply not specify it.
The downside is that the number of DNS queries might increase, because
the search domains are tried in order (which is why "." is better
than "..svc").
Verification
N/A