Adding --objstore.config to thanos recieve ingestor, without this flag, it's not writing to minio or any object storage #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrajdas
force-pushed
the
add-object-storage
branch
from
05f3a1a to
f718195
Compare
…g, it's not writing to minio or any object storage Signed-off-by: Raj Babu Das <[email protected]> Signed-off-by: Raj Babu Das <[email protected]>
imrajdas
force-pushed
the
add-object-storage
branch
from
f718195 to
d94edbf
Compare
Author
|
Hi @yeya24 , Is the ci build check required for this PR? It's checking the git diff --exit-code 0 |
Contributor
|
@imrajdas Yeah I think so. Please update the jsonnet files instead https://github.com/thanos-io/kube-thanos/blob/main/jsonnet/kube-thanos/kube-thanos-receive-ingestor.libsonnet. |
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Thank you, could you please add the jsonnet for the YAML changes as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification