Draft: Remove replicaLabel assertion from kube-thanos-receive & Update Docs #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-burt
changed the title
…les & docs Signed-off-by: Michael Burt <[email protected]>
michael-burt
force-pushed
the
receive-replicalabel
branch
from
5864685 to
216275a
Compare
| }; | ||
|
|
||
| local i = t.receiveIngestor(commonConfig.config { | ||
| labels: [ |
There was a problem hiding this comment.
Cold you adjust default labels in
instead of overriding them in example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Burt [email protected]
Changes
This PR removes the
replicaLabelassertion injsonnet/kube-thanos-receive.libsonnetsince it is not required if you are not also deploying Thanos Query. It also updates the documentation with examples on how to properly add a replication label as an external label on Thanos Receive ingestor.Verification
I have tested this in a cluster.