feat: update postgres to use as dependency from bitnami#16
Open
NathanAlcantara wants to merge 2 commits intoth0th:mainfrom
Open
feat: update postgres to use as dependency from bitnami#16NathanAlcantara wants to merge 2 commits intoth0th:mainfrom
NathanAlcantara wants to merge 2 commits intoth0th:mainfrom
Conversation
NathanAlcantara
force-pushed
the
listmonk/update-postgres
branch
from
7935924 to
6c0ebdc
Compare
NathanAlcantara
force-pushed
the
listmonk/update-postgres
branch
from
6c0ebdc to
8b534c5
Compare
Signed-off-by: Nathan Alcantara <nathan.alcantara@senior.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use an external postgres and don't expose the password on values.yaml or even on deployment (with kubectl describe for example) I move the implementation to use the official chart from postgres, on this way you can prevent the password to be expose using externalSecret and plus the other functionalities from official chart without worries about implement yourself.