You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added one test for uploading images and one for pdf documents.
The Document DTO currently expects the Type field to either be the string document_url or image_url. This is honestly a bit nonsensical, it would probably make more sense to use hierarchical types here (e.g. an abstract Document class that is implemented by an ImageDocument or DocumentDocument(? PdfDocument?)). Not sure what fits the project best.
Hi @KMikeeU, so I think you're on the right track with an Abtract Document class, then using a custom converter to toggle between the document_url or image_url. If you look at my repo tghamm/Anthropic.SDK, I make pretty heavy use of this pattern there, and it seems to serve the sdk pretty well. Would you be willing to give that a go?
Thanks so much for contributing to the library!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Missing tests, but please let me know what you think!