Add support for firmware 1.1.8+ WebRTC protocol (data2=2) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AES-GCM decryption for encrypted con_notify response - Check data2 field to detect protocol version 2 - Decrypt data1 before extracting RSA key when data2=2 - Add cryptography package dependency - Replace print with logger.warning for consistency This fixes the 'RSA key format is not supported' error that occurs with firmware 1.1.8+ which encrypts the data1 field in the con_notify response using AES-GCM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 'RSA key format is not supported' error that occurs with firmware 1.1.8+ which encrypts the data1 field in the con_notify response using AES-GCM.