Skip to content

chore: migrate to mise.toml #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
3w36zj6 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: migrate to mise.toml #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1420acf
chore: migrate to `mise.toml`
3w36zj6 Mar 1, 2026
b579715
ci: migrate release workflow to `mise.toml`
3w36zj6 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ jobs:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
- uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
- name: Get Node.js version from mise.toml
id: node-version
run: echo "version=$(mise ls --local --json | jq -r '.node[0].requested_version')" >> "$GITHUB_OUTPUT"

Copilot AI Mar 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mise ls JSON is being queried with .node[0].requested_version, but mise.toml defines the tool as nodejs. This likely makes the jq expression fail at runtime (missing key) and will break publishing. Update the jq filter (or the tool name in mise.toml) so the JSON key matches, and consider using a more direct command like mise current <tool> to avoid relying on ls output structure.

Suggested change
run: echo "version=$(mise ls --local --json | jq -r '.node[0].requested_version')" >> "$GITHUB_OUTPUT"
run: echo "version=$(mise ls --local --json | jq -r '.nodejs[0].requested_version')" >> "$GITHUB_OUTPUT"

Copilot uses AI. Check for mistakes.
- uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
Comment on lines +19 to 23

Copilot AI Mar 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow likely installs Node.js twice: once via jdx/mise-action (because mise.toml includes nodejs) and again via actions/setup-node. That adds unnecessary time and potential version drift. Consider configuring mise-action to only install the non-Node tools needed here (e.g., bun/jq) or rely on mise for Node and avoid reinstalling it with setup-node (while still configuring npm auth/registry).

Copilot uses AI. Check for mistakes.
with:
node-version-file: ".tool-versions"
node-version: ${{ steps.node-version.outputs.version }}
registry-url: "https://registry.npmjs.org"
- uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
with:
bun-version-file: ".tool-versions"
- run: bun install --frozen-lockfile
- run: npm run build
- run: npm publish --provenance
6 changes: 0 additions & 6 deletions .tool-versions
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[tools]
bun="1.2.13"
nodejs="24.12.0"
Comment thread
3w36zj6 marked this conversation as resolved.
pinact="3.2.0"
zizmor="1.18.0"
actionlint="1.7.9"
ghalint="1.5.3"
Comment thread
3w36zj6 marked this conversation as resolved.
jq = "1.8.1"

Copilot AI Mar 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mise.toml, jq is the only entry using spaced = (jq = "1.8.1") while the rest use tool="version". Consider normalizing the formatting for consistency to reduce churn in future edits.

Suggested change
jq = "1.8.1"
jq="1.8.1"

Copilot uses AI. Check for mistakes.