Skip to content

refactor(spritz): rename extension schema kind fields to type#157

Merged
onutc merged 10 commits intomainfrom
codex-spritz-schema-type
Mar 25, 2026
Merged

refactor(spritz): rename extension schema kind fields to type#157
onutc merged 10 commits intomainfrom
codex-spritz-schema-type

Conversation

@onutc
Copy link
Copy Markdown
Member

@onutc onutc commented Mar 25, 2026

TL;DR

Rename the recent Spritz extension/runtime schema fields from kind to type.
Keep kind out of the recent Spritz data structures and examples.

Summary

  • rename the extension config and resolver envelope schema from kind to type
  • rename runtime binding owner principal output from kind to type
  • update tests, docs, and AGENTS guidance to match the new schema

Review focus

  • extension registry parsing and emitted resolver envelopes
  • runtime binding response shape consumed by platform
  • docs/examples now matching the shipped schema

Test plan

  • cd /Users/onur/repos/spritz && gofmt -w api/extensions.go api/runtime_bindings.go api/extensions_test.go api/channel_routes_test.go api/create_admission_test.go
  • cd /Users/onur/repos/spritz/api && go test ./...
  • cd /Users/onur/repos/spritz && npx -y @simpledoc/simpledoc check docs/2026-03-19-runtime-binding-resolution-api-implementation-plan.md docs/2026-03-19-unified-extension-framework-architecture.md docs/2026-03-23-shared-app-tenant-routing-architecture.md

@onutc onutc merged commit 428cd0f into main Mar 25, 2026
5 checks passed
@onutc onutc deleted the codex-spritz-schema-type branch March 25, 2026 09:08
@gitrank-connector
Copy link
Copy Markdown

👍 GitRank PR Analysis

Score: 5 points

Metric Value
Component Other (1× multiplier)
Severity P3 - Low (5 base pts)
Final Score 5 × 1 = 5

Eligibility Checks

Check Status
Issue/Bug Fix
Fix Implementation
PR Documented
Tests
Lines Within Limit

Impact Summary

This PR systematically renames extension schema fields from 'kind' to 'type' across the codebase, including extension registry parsing, runtime binding responses, and documentation. The change establishes a new naming convention documented in AGENTS.md and updates 16 files with corresponding test updates. All changes are internal schema/API contract updates with comprehensive test coverage for the new behavior.

Analysis Details

Component Classification: This is a schema refactoring that affects multiple components (extensions, runtime bindings, channel conversations) without introducing new functionality. Classified as OTHER since it's a cross-cutting naming convention change rather than a specific feature or bug fix.

Severity Justification: This is a P3 (Low) severity change. It's a non-breaking internal refactoring that renames schema fields from 'kind' to 'type' for consistency. While it touches many files, it's purely a naming convention update with no functional impact on business logic or user-facing behavior.

Eligibility Notes: Tests are required for this change type because it modifies API contracts and schema structures that are consumed by external systems. The PR includes extensive test additions (312 lines in channel_conversations_test.go, 235 lines in gateway_test.go) covering the refactored functionality, new alias persistence logic, and legacy conversation reuse patterns. The fix_implementation is true as the code changes align with the stated goal of renaming 'kind' to 'type' throughout. PR is well-documented with clear description of changes and test plan.


Analyzed by GitRank 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant