Skip to content

Conversation

@regressEdo
Copy link

New release 3.0.0 got released: https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v3.0.0 but the current version constraint doesn't allow the upgrade

@regressEdo regressEdo requested review from a team, apeabody and ericyz as code owners December 8, 2025 16:36
@google-cla
Copy link

google-cla bot commented Dec 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @regressEdo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version constraint for the Kubernetes Terraform provider within the project's configuration. The modification specifically allows the use of version 3.0.0 of the provider, which was previously blocked by an older constraint. This ensures the project can leverage the latest features and improvements offered by the new provider release.

Highlights

  • Kubernetes Provider Version Update: The version constraint for the hashicorp/kubernetes Terraform provider has been updated to allow for the recently released v3.0.0.
  • Compatibility Enhancement: This change ensures that the project can now utilize v3.0.0 of the Kubernetes provider, addressing the issue where the previous constraint prevented its adoption.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kubernetes provider version constraint to allow the new 3.0.0 release. The change in versions.tf is correct in its intent, but it is incomplete as the same version constraint is hardcoded in several other module and example files. Furthermore, the change introduces a compatibility issue with older patch versions of Terraform 0.13. I've left a detailed comment on the change with information on the other files that need to be updated for consistency and how to resolve the compatibility problem.

versions.tf Outdated
kubernetes = {
source = "hashicorp/kubernetes"
version = "~> 2.10"
version = "~> 2.10, ~> 3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change is a good start, but it's incomplete and introduces a potential compatibility issue.

  1. Incomplete Change: The Kubernetes provider version constraint needs to be updated consistently across the repository.

    • The template file autogen/main/versions.tf.tmpl still uses version = "~> 2.10" in two places. This template generates the versions.tf file for many submodules. Please update both occurrences to "~> 2.10, ~> 3.0".
    • After updating the template and regenerating files, please verify other manual occurrences, like in examples/simple_zonal_with_acm/versions.tf.
  2. Terraform Version Compatibility: Using multiple ~> constraints for a provider version was buggy in Terraform v0.13.0 and v0.13.1 and was fixed in v0.13.2. Since this module has required_version = ">= 0.13", users on those older patch versions will encounter errors. Please consider bumping the required_version to at least >= 0.13.2 in all relevant versions.tf files to ensure compatibility.

Addressing these points will make the module more robust and consistent.

@regressEdo regressEdo force-pushed the feature/include-new-constraint-version-for-kubernetes branch 2 times, most recently from b370f1e to c494236 Compare December 8, 2025 16:57
@regressEdo regressEdo changed the title Also allow kubernetes version constraint ~>3.0.0 as new release Allow new hashicorp/kubernetes version 3.0.0 Dec 8, 2025
@regressEdo regressEdo force-pushed the feature/include-new-constraint-version-for-kubernetes branch from c494236 to 1a8a1a0 Compare December 8, 2025 16:58
@apeabody
Copy link
Collaborator

apeabody commented Dec 9, 2025

Hi @regressEdo - Can you please rebase? It looks like this PR is against a pretty old version of the repo. Thanks!

@regressEdo regressEdo closed this Dec 10, 2025
@regressEdo regressEdo force-pushed the feature/include-new-constraint-version-for-kubernetes branch from 1a8a1a0 to e268ba7 Compare December 10, 2025 08:47
@regressEdo regressEdo deleted the feature/include-new-constraint-version-for-kubernetes branch December 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants