-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow new hashicorp/kubernetes version 3.0.0 #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow new hashicorp/kubernetes version 3.0.0 #2499
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @regressEdo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version constraint for the Kubernetes Terraform provider within the project's configuration. The modification specifically allows the use of version 3.0.0 of the provider, which was previously blocked by an older constraint. This ensures the project can leverage the latest features and improvements offered by the new provider release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Kubernetes provider version constraint to allow the new 3.0.0 release. The change in versions.tf is correct in its intent, but it is incomplete as the same version constraint is hardcoded in several other module and example files. Furthermore, the change introduces a compatibility issue with older patch versions of Terraform 0.13. I've left a detailed comment on the change with information on the other files that need to be updated for consistency and how to resolve the compatibility problem.
versions.tf
Outdated
| kubernetes = { | ||
| source = "hashicorp/kubernetes" | ||
| version = "~> 2.10" | ||
| version = "~> 2.10, ~> 3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a good start, but it's incomplete and introduces a potential compatibility issue.
-
Incomplete Change: The Kubernetes provider version constraint needs to be updated consistently across the repository.
- The template file
autogen/main/versions.tf.tmplstill usesversion = "~> 2.10"in two places. This template generates theversions.tffile for many submodules. Please update both occurrences to"~> 2.10, ~> 3.0". - After updating the template and regenerating files, please verify other manual occurrences, like in
examples/simple_zonal_with_acm/versions.tf.
- The template file
-
Terraform Version Compatibility: Using multiple
~>constraints for a provider version was buggy in Terraform v0.13.0 and v0.13.1 and was fixed in v0.13.2. Since this module hasrequired_version = ">= 0.13", users on those older patch versions will encounter errors. Please consider bumping therequired_versionto at least>= 0.13.2in all relevantversions.tffiles to ensure compatibility.
Addressing these points will make the module more robust and consistent.
b370f1e to
c494236
Compare
c494236 to
1a8a1a0
Compare
|
Hi @regressEdo - Can you please rebase? It looks like this PR is against a pretty old version of the repo. Thanks! |
1a8a1a0 to
e268ba7
Compare
New release 3.0.0 got released: https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v3.0.0 but the current version constraint doesn't allow the upgrade