-
-
Notifications
You must be signed in to change notification settings - Fork 266
feat: Add timeouts block for vpc origin resource #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ah, this module still supports Terraform 0.13.x which means we won't be able to use variable optional attributes (1.3+) we'll have to wait to take a breaking change to update |
@bryantbiggs |
Hi @bryantbiggs! Can this pull request still be merged or should changes be made to |
Description
Adds timeouts configuration for vpc origin resource.
Motivation and Context
Solves #163
VPC Origin creation can be longer than default terraform timeout, which stops deployments and forces to manually untaint resource before continuing deployment.
This PR adds an optional timeout configuration in the
vpc_origin
variable and uses this configuration in theaws_cloudfront_vpc_origin
resource.Breaking Changes
N/A
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request