Conversation
|
If someone knows how to build binary and test this, please do and give me results |
b6b3308 to
1ecb24a
Compare
TomJo2000
left a comment
There was a problem hiding this comment.
It would be nice for the pkg completions to use the existing apt or pacman completers.
Although I'm not 100% sure how to properly call another completer in a completer or if that's even possible.
I think complete -F should handle it for Bash, but I'm unsure about Zsh and Fish.
|
Updated completions according to the review comments:
|
1ecb24a to
fd1965b
Compare
|
@TomJo2000 Now everything addressed? |
I've left you a comment above regarding the LLM's "response" for why it doesn't wanna do this in a sane way (#390 (comment)). Other than that I'm okay with the changes in the latest push ( One more thing we should probably add as part of this PR is proper highlighting for the completions files in GitHub's code view. # File syntax
completions/bash/* linguist-language=bash
completions/fish/* linguist-language=fish
completions/zsh/* linguist-language=zsh(The |
fd1965b to
b8b8445
Compare
|
Added .gitattributes |
|
Yeah, GitHub only applies .gitattributes to PR diffs once it's in the base branch. Good to see it picked up on the tree view. |
|
@TomJo2000 PR is ready for merge, right? |
TomJo2000
left a comment
There was a problem hiding this comment.
Most of what I've written for the Bash completion also applies for Zsh.
b8b8445 to
2a13960
Compare
|
Addressed the review feedback in the latest push:
|
2a13960 to
be080f7
Compare
|
@TomJo2000 Now everything good? |
be080f7 to
b6a2c1a
Compare
|
Updated Reverted |
b6a2c1a to
00c0ad4
Compare
|
@TomJo2000 Now everything addressed? No issues? |
00c0ad4 to
f6f08bf
Compare
|
Updated the known shells list across all three shells:
Also ran a full compilation and sandbox installation/uninstallation test via |
|
@TomJo2000 Now good? |
|
I'll need to look at it after work. Might take a while to find and address everything. |
f6f08bf to
d72f3ad
Compare
|
Added |
d72f3ad to
f9a04df
Compare
|
Added |

Adds tab completions for
pkg,termux-open,termux-backup,termux-restore,termux-info, andchshacross Bash, Zsh, and Fish. Integrated into Autotools viacompletions/Makefile.am.