Skip to content

Added some more convenience functions ...#7

Open
andre-dietrich wants to merge 2 commits intoterezka:masterfrom
andre-dietrich:master
Open

Added some more convenience functions ...#7
andre-dietrich wants to merge 2 commits intoterezka:masterfrom
andre-dietrich:master

Conversation

@andre-dietrich
Copy link
Copy Markdown

... such as oneOf, or, faked lazy, keyValuePairs, and null. Unfortunately, elm-format changed the file a bit, so that there seem to be more changes, but there aren't.

Regards

@MaybeJustJames
Copy link
Copy Markdown

I suppose this needs tests before being merged?

Comment on lines +343 to +344
Just err ->
Err (Decoding "Expected record")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a helpful error message. Maybe something like:

Suggested change
Just err ->
Err (Decoding "Expected record")
Just ( _, Err (Decoding problem) ) ->
Err (Decoding problem)

@andre-dietrich
Copy link
Copy Markdown
Author

Hi, this functionality has never been merged, I guess, the easiest way to use it, is to clone my fork or use it as a local submodule...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants