Skip to content

Add testing workflow for C++ tests #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add testing workflow for C++ tests #2263

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
91d0d44
Add basic C++ tests workflow
smokestacklightnin Sep 1, 2024
a14e842
Add verbose failures flag
smokestacklightnin Sep 1, 2024
04f1a2f
Add test output flag
smokestacklightnin Sep 1, 2024
b0b35f6
Prepend `DISABLED_` to test names corresponding to failing tests
smokestacklightnin Sep 7, 2024
ea51496
Try expunge after build
smokestacklightnin Oct 21, 2024
e86e4d8
remove `--verbose-errors`
smokestacklightnin Oct 23, 2024
f2ffccf
Separate into steps
smokestacklightnin Oct 23, 2024
9b6874d
Merge remote-tracking branch 'upstream/master' into ci/testing/add-wo…
smokestacklightnin May 1, 2025
f00d37f
Merge remote-tracking branch 'upstream/master' into ci/testing/add-wo…
smokestacklightnin Jul 1, 2025
5dda2ff
Merge remote-tracking branch 'upstream/master' into ci/testing/add-wo…
smokestacklightnin Jul 2, 2025
6805a9a
Remove line about copybara because it is disabled
smokestacklightnin Jul 2, 2025
eacf380
Remove unnecessary build and clean steps
smokestacklightnin Jul 2, 2025
540f0e5
Remove setup-bazel because it is already installed on the github runner
smokestacklightnin Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .github/workflows/ci-test-cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Github action definitions for C++ unit-tests with PRs.

name: tf-serving-cpp-unit-tests
on:
pull_request:
branches: [ master ]
paths-ignore:
- '**.md'
- 'docs/**'
workflow_dispatch:
# Remove `push` trigger before merge
push:


env:
USE_BAZEL_VERSION: "6.5.0"
# Changed to match tensorflow
# https://github.com/tensorflow/tensorflow/blob/master/.bazelversion

jobs:
tests:
if: github.actor != 'copybara-service[bot]'
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Set up Bazel
uses: bazel-contrib/[email protected]
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}-${{ hashFiles('.github/workflows/ci-test.yml') }}
# Share repository cache between workflows.
repository-cache: true

- name: Build unit tests
shell: bash
run: |
bazel build //tensorflow_serving/...

- name: Clean unit test artifacts
shell: bash
run: |
bazel clean --expunge

- name: Run unit tests
shell: bash
run: |
bazel test //tensorflow_serving/... --test_output=errors
40 changes: 20 additions & 20 deletions tensorflow_serving/batching/batching_session_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class BatchingSessionTest : public ::testing::TestWithParam<bool> {
}
};

TEST_P(BatchingSessionTest, Basic) {
TEST_P(BatchingSessionTest, DISABLED_Basic) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 4; // fits two 2-unit tasks
schedule_options.batch_timeout_micros = 1 * 1000 * 1000; // won't trigger
Expand All @@ -315,7 +315,7 @@ TEST_P(BatchingSessionTest, Basic) {
}));
}

TEST_P(BatchingSessionTest, BatchingWithPadding) {
TEST_P(BatchingSessionTest, DISABLED_BatchingWithPadding) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 2;
schedule_options.batch_timeout_micros = 1e6;
Expand Down Expand Up @@ -344,7 +344,7 @@ TEST_P(BatchingSessionTest, BatchingWithPadding) {
}));
}

TEST_P(BatchingSessionTest, BatchingWithLargeBatch) {
TEST_P(BatchingSessionTest, DISABLED_BatchingWithLargeBatch) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 3;
schedule_options.batch_timeout_micros = 1e6;
Expand Down Expand Up @@ -400,7 +400,7 @@ TEST_P(BatchingSessionTest, BatchingWithLargeBatch) {
}
}

TEST_P(BatchingSessionTest, BatchHandlesSplitError) {
TEST_P(BatchingSessionTest, DISABLED_BatchHandlesSplitError) {
if (!enable_large_batch_splitting()) {
return;
}
Expand Down Expand Up @@ -441,7 +441,7 @@ TEST_P(BatchingSessionTest, BatchHandlesSplitError) {
}));
}

TEST_P(BatchingSessionTest, BatchingLazySplit) {
TEST_P(BatchingSessionTest, DISABLED_BatchingLazySplit) {
if (!enable_large_batch_splitting()) {
return;
}
Expand Down Expand Up @@ -472,7 +472,7 @@ TEST_P(BatchingSessionTest, BatchingLazySplit) {
}));
}

TEST(BatchingSessionTest, BatchingWithPaddingAndCost) {
TEST(BatchingSessionTest, DISABLED_BatchingWithPaddingAndCost) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 2;
schedule_options.batch_timeout_micros = 1e6;
Expand Down Expand Up @@ -535,7 +535,7 @@ TEST(BatchingSessionTest, BatchingWithPaddingAndCost) {
}));
}

TEST_P(BatchingSessionTest, BatchingWithCost) {
TEST_P(BatchingSessionTest, DISABLED_BatchingWithCost) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 3;
schedule_options.batch_timeout_micros = 1e6;
Expand Down Expand Up @@ -623,7 +623,7 @@ TEST_P(BatchingSessionTest, BatchingWithCost) {
}
}

TEST_P(BatchingSessionTest, UnequalTensorShapesWithPaddingTurnedOff) {
TEST_P(BatchingSessionTest, DISABLED_UnequalTensorShapesWithPaddingTurnedOff) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 2;
schedule_options.batch_timeout_micros = 1e6;
Expand Down Expand Up @@ -657,7 +657,7 @@ TEST_P(BatchingSessionTest, UnequalTensorShapesWithPaddingTurnedOff) {
}));
}

TEST_P(BatchingSessionTest, SingletonBatch) {
TEST_P(BatchingSessionTest, DISABLED_SingletonBatch) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 4; // fits two 2-unit tasks
schedule_options.batch_timeout_micros = 0;
Expand All @@ -672,7 +672,7 @@ TEST_P(BatchingSessionTest, SingletonBatch) {
batching_session.get());
}

TEST_P(BatchingSessionTest, RequestThatDoesntMatchSignatureGetsRunAnyway) {
TEST_P(BatchingSessionTest, DISABLED_RequestThatDoesntMatchSignatureGetsRunAnyway) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
// Set the batching parameters s.t. if the request is batched the test will
// timeout.
Expand All @@ -689,7 +689,7 @@ TEST_P(BatchingSessionTest, RequestThatDoesntMatchSignatureGetsRunAnyway) {
batching_session.get());
}

TEST_P(BatchingSessionTest, RequestWithIncompatibleInputTensorSizes) {
TEST_P(BatchingSessionTest, DISABLED_RequestWithIncompatibleInputTensorSizes) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options = annotate_options(schedule_options);
std::unique_ptr<Session> batching_session;
Expand Down Expand Up @@ -723,7 +723,7 @@ TEST_P(BatchingSessionTest, RequestWithIncompatibleInputTensorSizes) {
GetPercentileTotal("/tensorflow/serving/batching_session/padding_size"));
}

TEST_P(BatchingSessionTest, AllowedBatchSizesNoPaddingNeeded) {
TEST_P(BatchingSessionTest, DISABLED_AllowedBatchSizesNoPaddingNeeded) {
int32 start_input_value = GetPercentileTotal(
"/tensorflow/serving/batching_session/input_batch_size");
int32 start_process_value = GetPercentileTotal(
Expand Down Expand Up @@ -764,7 +764,7 @@ TEST_P(BatchingSessionTest, AllowedBatchSizesNoPaddingNeeded) {
GetPercentileTotal("/tensorflow/serving/batching_session/padding_size"));
}

TEST_P(BatchingSessionTest, AllowedBatchSizesRequirePadding) {
TEST_P(BatchingSessionTest, DISABLED_AllowedBatchSizesRequirePadding) {
int32 start_input_value = GetPercentileTotal(
"/tensorflow/serving/batching_session/input_batch_size");
int32 start_process_value = GetPercentileTotal(
Expand Down Expand Up @@ -816,7 +816,7 @@ TEST_P(BatchingSessionTest, AllowedBatchSizesRequirePadding) {
"Tracks the batch size distribution on processing.", {}));
}

TEST_P(BatchingSessionTest, UnsortedAllowedBatchSizesRejected) {
TEST_P(BatchingSessionTest, DISABLED_UnsortedAllowedBatchSizesRejected) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 4;
schedule_options = annotate_options(schedule_options);
Expand All @@ -830,7 +830,7 @@ TEST_P(BatchingSessionTest, UnsortedAllowedBatchSizesRejected) {
}

TEST_P(BatchingSessionTest,
FinalAllowedBatchSizeLargerThanMaxBatchSizeRejected) {
DISABLED_FinalAllowedBatchSizeLargerThanMaxBatchSizeRejected) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 4;
schedule_options = annotate_options(schedule_options);
Expand All @@ -846,7 +846,7 @@ TEST_P(BatchingSessionTest,
: "max_batch_size"));
}

TEST_P(BatchingSessionTest, DifferentOrderForInputAndOutputTensors) {
TEST_P(BatchingSessionTest, DISABLED_DifferentOrderForInputAndOutputTensors) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 6; // fits three 2-unit tasks
schedule_options.batch_timeout_micros = 1 * 1000 * 1000; // won't trigger
Expand Down Expand Up @@ -895,7 +895,7 @@ TEST_P(BatchingSessionTest, DifferentOrderForInputAndOutputTensors) {
}));
}

TEST_P(BatchingSessionTest, MultipleSignatures) {
TEST_P(BatchingSessionTest, DISABLED_MultipleSignatures) {
std::vector<BatchScheduler<BatchingSessionTask>*> schedulers;
auto create_scheduler =
[&schedulers, this](
Expand Down Expand Up @@ -963,7 +963,7 @@ TEST_P(BatchingSessionTest, MultipleSignatures) {
EXPECT_EQ(0, schedulers[1]->NumEnqueuedTasks());
}

TEST_P(BatchingSessionTest, EnqueuedLongerThanTimeout) {
TEST_P(BatchingSessionTest, DISABLED_EnqueuedLongerThanTimeout) {
BatchScheduler<BatchingSessionTask>* scheduler = nullptr;
auto create_scheduler =
[&scheduler, this](
Expand Down Expand Up @@ -1021,7 +1021,7 @@ TEST_P(BatchingSessionTest, EnqueuedLongerThanTimeout) {
request_returned.WaitForNotification();
}

TEST_P(BatchingSessionTest, ThreadPoolOptions) {
TEST_P(BatchingSessionTest, DISABLED_ThreadPoolOptions) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 3;
schedule_options.batch_timeout_micros = 1 * 1000 * 1000; // won't trigger
Expand Down Expand Up @@ -1055,7 +1055,7 @@ TEST_P(BatchingSessionTest, ThreadPoolOptions) {
}));
}

TEST_P(BatchingSessionTest, SubsetOutputTensors) {
TEST_P(BatchingSessionTest, DISABLED_SubsetOutputTensors) {
BasicBatchScheduler<BatchingSessionTask>::Options schedule_options;
schedule_options.max_batch_size = 6; // fits three 2-unit tasks
schedule_options.batch_timeout_micros = 1 * 1000 * 1000; // won't trigger
Expand Down
8 changes: 4 additions & 4 deletions tensorflow_serving/servables/tensorflow/bundle_factory_util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ TEST_F(BundleFactoryUtilTest, GetRunOptions) {
EXPECT_THAT(GetRunOptions(bundle_config), EqualsProto(want));
}

TEST_F(BundleFactoryUtilTest, WrapSession) {
TEST_F(BundleFactoryUtilTest, DISABLED_WrapSession) {
SavedModelBundle bundle;
TF_ASSERT_OK(LoadSavedModel(SessionOptions(), RunOptions(), export_dir_,
{"serve"}, &bundle));
Expand All @@ -134,7 +134,7 @@ TEST_F(BundleFactoryUtilTest, WrapSessionIgnoreThreadPoolOptions) {
test_util::TestSingleRequest(session.get());
}

TEST_F(BundleFactoryUtilTest, WrapSessionForBatching) {
TEST_F(BundleFactoryUtilTest, DISABLED_WrapSessionForBatching) {
SavedModelBundle bundle;
TF_ASSERT_OK(LoadSavedModel(SessionOptions(), RunOptions(), export_dir_,
{"serve"}, &bundle));
Expand All @@ -156,7 +156,7 @@ TEST_F(BundleFactoryUtilTest, WrapSessionForBatching) {
test_util::TestMultipleRequests(bundle.session.get(), 10, 2);
}

TEST_F(BundleFactoryUtilTest, WrapSessionForBatchingConfigError) {
TEST_F(BundleFactoryUtilTest, DISABLED_WrapSessionForBatchingConfigError) {
BatchingParameters batching_params;
batching_params.mutable_max_batch_size()->set_value(2);
// The last entry in 'allowed_batch_sizes' is supposed to equal
Expand Down Expand Up @@ -227,7 +227,7 @@ TEST_F(BundleFactoryUtilTest, EstimateResourceFromPathWithBadExport) {
EXPECT_FALSE(status.ok());
}

TEST_F(BundleFactoryUtilTest, EstimateResourceFromPathWithGoodExport) {
TEST_F(BundleFactoryUtilTest, DISABLED_EstimateResourceFromPathWithGoodExport) {
const double kTotalFileSize = test_util::GetTotalFileSize(
test_util::GetTestSavedModelBundleExportFiles());
ResourceAllocation expected =
Expand Down
2 changes: 1 addition & 1 deletion tensorflow_serving/servables/tensorflow/machine_learning_metadata_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ TEST(MachineLearningMetaDataTest, BasicTest_MLMD_missing) {
EXPECT_FALSE(GetMlmdUuid("missing_model", "9696", &mlmd_uuid));
}

TEST(MachineLearningMetaDataTest, BasicTest_MLMD_present) {
TEST(MachineLearningMetaDataTest, DISABLED_BasicTest_MLMD_present) {
std::string mlmd_uuid;
ASSERT_FALSE(GetMlmdUuid("test_model", "9696", &mlmd_uuid));
const string test_data_path = test_util::TestSrcDirPath(
Expand Down
4 changes: 2 additions & 2 deletions tensorflow_serving/servables/tensorflow/saved_model_config_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ TEST(ModelRuntimeConfigTest, EmptyModelConfig) {
EXPECT_EQ(runtime_config.ToProto().config_size(), 0);
}

TEST(ModelRuntimeConfigTest, OverwriteRuntimeConfig) {
TEST(ModelRuntimeConfigTest, DISABLED_OverwriteRuntimeConfig) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithModelConfigPath);
tensorflow::GraphOptions graph_options;
Expand All @@ -101,7 +101,7 @@ TEST(ModelRuntimeConfigTest, OverwriteRuntimeConfig) {
)pb"));
}

TEST(ModelRuntimeConfigTest, ModelConfig) {
TEST(ModelRuntimeConfigTest, DISABLED_ModelConfig) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithModelConfigPath);
SavedModelConfig model_config;
Expand Down
6 changes: 3 additions & 3 deletions tensorflow_serving/servables/tensorflow/saved_model_config_util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ TEST(LoadSavedModelConfigTest, EmptySavedModelConfig) {
EXPECT_THAT(saved_model_config.value(), EqualsProto(""));
}

TEST(LoadSavedModelConfigTest, SavedModelConfig) {
TEST(LoadSavedModelConfigTest, DISABLED_SavedModelConfig) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithSavedModelConfigPath);
absl::StatusOr<SavedModelConfig> saved_model_config =
Expand Down Expand Up @@ -115,7 +115,7 @@ TEST(LoadSavedModelConfigTest, SavedModelConfig) {
EXPECT_THAT(saved_model_config.value(), EqualsProto(expected_config));
}

TEST(UpdateRewriterConfigTest, AddOptimizers) {
TEST(UpdateRewriterConfigTest, DISABLED_AddOptimizers) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithSavedModelConfigPath);
absl::StatusOr<SavedModelConfig> saved_model_config =
Expand Down Expand Up @@ -155,7 +155,7 @@ TEST(UpdateRewriterConfigTest, AddOptimizers) {
.SerializeAsString())))));
}

TEST(UpdateRewriterConfigTest, ReplaceOptimizers) {
TEST(UpdateRewriterConfigTest, DISABLED_ReplaceOptimizers) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithSavedModelConfigPath);
absl::StatusOr<SavedModelConfig> saved_model_config =
Expand Down
4 changes: 2 additions & 2 deletions tensorflow_serving/session_bundle/oss/session_bundle_util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ TEST(SessionBundleTest, ConvertSessionBundleToSavedModelBundleTest) {
::testing::HasSubstr("Session Bundle is deprecated and removed."));
}

TEST(SessionBundleTest, LoadSessionBundleOrSavedModelBundleTest) {
TEST(SessionBundleTest, DISABLED_LoadSessionBundleOrSavedModelBundleTest) {
SessionOptions session_options;
RunOptions run_options;
SavedModelBundle bundle;
Expand All @@ -68,7 +68,7 @@ TEST(SessionBundleTest, LoadSessionBundleOrSavedModelBundleTest) {
EXPECT_TRUE(status.ok());
}

TEST(SessionBundleTest, LoadSessionBundleOrSavedModelBundleFailureTest) {
TEST(SessionBundleTest, DISABLED_LoadSessionBundleOrSavedModelBundleFailureTest) {
SessionOptions session_options;
RunOptions run_options;
SavedModelBundle bundle;
Expand Down
2 changes: 1 addition & 1 deletion tensorflow_serving/session_bundle/saved_model_config_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ TEST(SavedModelConfigTest, EmptySavedModelConfig) {
EXPECT_EQ(custom_optimizers.size(), 0);
}

TEST(SavedModelConfigTest, SavedModelConfig) {
TEST(SavedModelConfigTest, DISABLED_SavedModelConfig) {
const std::string export_dir =
test_util::TestSrcDirPath(kTestSavedModelWithSavedModelConfigPath);

Expand Down
Loading