Add optional TBLIS CPU contraction provider - #1343
Closed
Ryo-wtnb11 wants to merge 2 commits into
Closed
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by internal-branch PR #1344 so repository rules review can run on a non-external PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
cpu-tblisprovider on the CPU backend, with fallback to the existing CPU path when TBLIS is unavailable or not selectedtenferro-tblis-src, with a pinned TBLIS commit and static linking so the runtime/test/bench binaries do not depend onlibtblis.dylibTests run:
cargo test -p tenferro-cpu --no-default-features --features cpu-faer,cpu-tblispassed: 220 unit tests, 7 backend capability tests, 3 provider feature tests, 25 runtime error tests, 61 doctestscargo check -p tenferro-runtime --no-default-features --features cpu-faer,cpu-tblispassedcargo check -p tenferro-linalg --no-default-features --features cpu-faer,cpu-tblispassedcargo check -p tenferro-cpu --no-default-features --features cpu-faer,cpu-tblis --benchespassedcargo check -p tenferro-cpu --no-default-features --features cpu-faer,cpu-tblis,blas-openblas --benchespassed after source-provider downloadscargo package -p tenferro-tblis-src --allow-dirty --offlinepassedcargo fmt --all --checkpassedgit diff --checkpassedotool -Lon the test/bench binaries showed nolibtblis.dylibdependencyBenchmarks:
TBLIS_NUM_THREADS=1,RAYON_NUM_THREADS=1,OMP_NUM_THREADS=1, and for the BLAS runsOPENBLAS_NUM_THREADS=1