refactor(bench): remove latency table from summary#3365
Closed
Conversation
Block time metrics (p50/p90/p99) already capture inter-block timing. The latency fields from report.json were computing the same thing, so drop them to avoid confusion. Co-authored-by: YK <46377366+yongkangc@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d3efe-b268-771a-a069-b5fa33370253
Clarify the user-facing block time labels in Slack and the generated summary. Co-Authored-By: YK <46377366+yongkangc@users.noreply.github.com>
Clarify which TPS metric is computed over the full run duration. Co-Authored-By: YK <46377366+yongkangc@users.noreply.github.com>
Show elapsed run time instead of mislabeled wall clock TPS in the bench summary and Slack output. Co-Authored-By: YK <46377366+yongkangc@users.noreply.github.com>
Rename the wall clock delta formatter to better reflect the metric and spread it formats. Co-Authored-By: YK <46377366+yongkangc@users.noreply.github.com>
Contributor
|
This PR has been marked stale due to 7 days of inactivity. |
Contributor
|
Closed due to inactivity. Reopen if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block time metrics (p50/p90/p99) already capture inter-block timing — the latency fields from report.json were computing the same thing. Drops all
latency_*fields from summary.json and removes the "Latency (Secondary)" table from summary.md to avoid confusion.Follow-up to #3348.
Prompted by: YK