fix(transaction-pool): reject queued txs discarded on insert#3360
Open
joohhnnn wants to merge 3 commits intotempoxyz:mainfrom
Open
fix(transaction-pool): reject queued txs discarded on insert#3360joohhnnn wants to merge 3 commits intotempoxyz:mainfrom
joohhnnn wants to merge 3 commits intotempoxyz:mainfrom
Conversation
mattsse
requested changes
Mar 30, 2026
Contributor
mattsse
left a comment
There was a problem hiding this comment.
this has unrelated changes
please reduce this to just the fix
mattsse
reviewed
Mar 30, 2026
Contributor
mattsse
left a comment
There was a problem hiding this comment.
I believe this is correct and we should return an error here because it's possible that this will discard the tx itself if its queued.
but this now introduces some side-effects because this will then bypass:
tempo/crates/transaction-pool/src/tempo_pool.rs
Lines 475 to 495 in e331e2f
so idk we should make this change like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns
DiscardedOnInsertwhen an AA2d queued transaction is immediately evicted bydiscard()during insertion instead of reporting it as parked.keeps AA2d pool insert semantics aligned with the standard pool and avoids reporting success for transactions that are no longer in the pool.