fix(transaction-pool): prevent protocol tx skips after aa2d invalidation#3359
Open
joohhnnn wants to merge 1 commit intotempoxyz:mainfrom
Open
fix(transaction-pool): prevent protocol tx skips after aa2d invalidation#3359joohhnnn wants to merge 1 commit intotempoxyz:mainfrom
joohhnnn wants to merge 1 commit intotempoxyz:mainfrom
Conversation
joohhnnn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AA2D and protocol-pool transactions shared the same sender-id namespace in the merged best-transaction iterator.
A failed
nonce_key > 0AA transaction could cause the merged best-transaction iterator to skip later validnonce_key = 0protocol-pool transactions from the same sender in the same payload-building pass. which means When an AA2D transaction failed during payload building,mark_invalid()propagated across pools, causing valid protocol-pool transactions from the same sender to be skipped in the same pass.Isolate AA2D sender ids from the protocol-pool namespace so that
mark_invalid()cannot leak invalidation across pools.