feat(bench): add run attribution to ClickHouse uploads

[yongkangc]

Closes RETH-669

Adds run_label, pr_number, baseline/feature refs, triggered_by, run_type,
and github_run_id/url to tempo_bench_runs inserts. Includes migration
SQL for the new columns.

---

Added in these on clickhouse:

ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS run_label String DEFAULT '' AFTER benchmark_mode;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS pr_number String DEFAULT '' AFTER run_label;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS baseline_ref String DEFAULT '' AFTER pr_number;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS feature_ref String DEFAULT '' AFTER baseline_ref;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS triggered_by String DEFAULT '' AFTER feature_ref;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS run_type String DEFAULT 'manual' AFTER triggered_by;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS github_run_id String DEFAULT '' AFTER run_type;
ALTER TABLE tempo_bench_runs ADD COLUMN IF NOT EXISTS github_run_url String DEFAULT '' AFTER github_run_id;

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eea85420c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Stop overwriting BENCH_JOB_URL with empty context

In the Upload results to ClickHouse step, setting BENCH_JOB_URL: ${{ env.BENCH_JOB_URL }} can blank out the URL exported earlier via core.exportVariable('BENCH_JOB_URL', jobUrl). The env expression context only includes workflow/job/step-declared env vars, not runtime runner env, so this expression resolves to an empty string and overrides the real value for this step. As a result, upload-clickhouse.sh inserts empty github_run_url values, defeating the new run attribution field.

Useful? React with 👍 / 👎.

[Copilot]

Pull request overview

Adds benchmark run attribution metadata to ClickHouse uploads so tempo_bench_runs rows can be linked back to the triggering PR/workflow run and compared across baseline/feature refs.

Changes:

• Extend tempo_bench_runs inserts with run attribution fields (label, PR number, baseline/feature refs, trigger info, GitHub run id/url).
• Add a ClickHouse migration to introduce the new columns.
• Populate baseline/feature refs and run type in the bench GitHub Actions workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
contrib/bench/upload-clickhouse.sh	Adds new attribution columns/values to the ClickHouse insert generation.
contrib/bench/migrations/001_add_run_attribution.sql	Adds ClickHouse ALTER TABLE statements for the new attribution columns.
.github/workflows/bench.yml	Exposes baseline/feature refs + run type (and passes job URL) to the upload step.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.