docs(specs): change DEX pair storage layout to be order-sensitive #1791
+155
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrobinson
requested review from
0xKitsune,
howydev and
legion2002
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fgimenez
approved these changes
Dec 31, 2025
Member
fgimenez
left a comment
fgimenez
left a comment
There was a problem hiding this comment.
lgtm, maybe for a follow up would be good to add a >2 hop routing test
| // or "down" (parent -> child). We start with the natural direction from | ||
| // `tokenIn` towards the LCA and flip once when we cross the LCA so that | ||
| // at most one hop has to check both orientations. | ||
| bool isBaseForQuote = true; |
Member
There was a problem hiding this comment.
nit, looks like isBaseForQuote is used for two purposes now:
- loop state (are we still going up)
- per-hop output (is this hop spending base to get quote)
these coincide bc paths are all up, then all down, but maybe we could use two separate variables to make it more clear?
This PR updates the stablecoin exchange precompile to reflect the spec changes introduced in `dr/dex-order-sensitive-keys`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how DEX pairs are keyed so that a pair that uses token A as a base token and token B as a quote token would be keyed differently from a pair that uses token B as a base token and token A as a quote token. This would be a breaking change that affects storage layout and cannot be implemented in a hard fork without a regenesis.