fix(sdk): make payload codec failable - #1431
Merged
Merged
Conversation
chris-olszewski
commented
Jul 29, 2026
| Next::new({ | ||
| let mut rpc_client = client.clone(); | ||
| move |input: ListSchedulesPageInput| -> BoxFuture< | ||
| fn list_schedules_stream<CT>(client: CT, opts: ListSchedulesOptions) -> ListSchedulesStream |
Member
Author
There was a problem hiding this comment.
Don't love this, but easiest way to allow us to hit this function with a fake client.
chris-olszewski
commented
Jul 29, 2026
Sushisource
approved these changes
Jul 29, 2026
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Huh, not sure how I just skipped that lol
Member
Author
Not sure how I only noticed it last week 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
PayloadCodectrait methods to now returnResult<_, PayloadConversionError>AsyncPayloadVisitor::visitto be faillable,PayloadVisitable::visit_payloads_mutis now responsible for failing when a visitor fails. GeneratedPayloadVisitableimpls now have?after theirvisitcalls.?Why?
Discovered this while working on client interceptors, codecs certainly can fail.
Checklist
Closes N/A
How was this tested:
Added integration tests to verify codec failures result in failed tasks that are retried. Small unit tests to ensure we fallback to un-encoded failures if a codec operation fails along with ensuring codec failures abort streaming responses.
Any docs updates needed?
N/A