feat(sdk): client interceptor - #1426
Merged
Merged
Conversation
chris-olszewski
marked this pull request as ready for review
July 25, 2026 23:43
Sushisource
approved these changes
Jul 27, 2026
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Generally looking good to me, a few small things.
chris-olszewski
force-pushed
the
olszewski/feat_client_interceptor_2
branch
from
July 29, 2026 00:39
d50c44d to
efe315e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adding
ClientInterceptoralong with methods on client interceptors vec on client options to register the interceptors.Adding
RpcOptionsto various client calls options.Add options structs to some client calls that were missing them.
Why?
Checklist
Closes [Feature Request] Client-side interceptors #1138
How was this tested:
Added some unit tests to ensure connection level rpc options get overridden by call specific ones. Very basic integration test making sure interceptor order is respected on calls.
Any docs updates needed?
N/A