Skip to content

Make eager activity reservation limit configurable#1424

Merged
Sushisource merged 2 commits into
mainfrom
eager-activity-slot-limit
Jul 24, 2026
Merged

Make eager activity reservation limit configurable#1424
Sushisource merged 2 commits into
mainfrom
eager-activity-slot-limit

Conversation

@Sushisource

@Sushisource Sushisource commented Jul 24, 2026

Copy link
Copy Markdown
Member

What changed

  • Replace Core's hardcoded limit of three eager activity slot reservations per workflow-task completion with max_eager_activity_reservations_per_workflow_task.
  • Preserve the existing default of three; setting the option to zero disables eager activity reservations.
  • Expose the same option through the Rust SDK and C bridge.
  • Cover configured reservation behavior and option propagation.

Why

Workers already cap the number of slots they attempt to reserve for eager activities while completing a workflow task. Making that cap configurable lets applications tune the reservation burst without introducing a separate execution-lifetime limit.

Validation

  • cargo test -p temporalio-sdk-core activity_tasks_from_completion_are_delivered
  • cargo test -p temporalio-sdk max_eager_activity_reservations_per_workflow_task_propagates
  • cargo check -p temporalio-sdk-core-c-bridge
  • cargo lint
  • cargo test-lint

No breaking changes; the default remains three.

@Sushisource Sushisource changed the title Expose eager activity concurrency limit Make eager activity reservation limit configurable Jul 24, 2026
@Sushisource
Sushisource marked this pull request as ready for review July 24, 2026 19:19
@Sushisource
Sushisource requested a review from a team as a code owner July 24, 2026 19:19
@Sushisource
Sushisource merged commit d276936 into main Jul 24, 2026
22 checks passed
@Sushisource
Sushisource deleted the eager-activity-slot-limit branch July 24, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants