Skip to content

💥 Replayer configuration from plugins #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 7, 2025
Merged

💥 Replayer configuration from plugins #1011

merged 17 commits into from
Aug 7, 2025

Conversation

tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Jul 30, 2025

What was changed

Added ability to configure replayer to plugins. Plugins as a whole have become abstract so that plugin authors need to consider the different components they may need to configure.

Why?

Checklist

  1. Closes [Feature Request] Worker plugin support for replayers #994

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 changed the title POC for replayer configuration from existing plugins Replayer configuration from plugins Aug 4, 2025
@tconley1428 tconley1428 marked this pull request as ready for review August 4, 2025 21:47
@tconley1428 tconley1428 requested a review from a team as a code owner August 4, 2025 21:47
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. If we could, I would blow everything up and extract the things that are needed for deterministic replay out of the client/worker config so there's only one thing, but, that ship's long sailed.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Also, even though they were experimental anyways, we like to call out breaking changes in the release notes, so lets try to remember to do that.

@tconley1428 tconley1428 changed the title Replayer configuration from plugins 💥 Replayer configuration from plugins Aug 6, 2025
@tconley1428 tconley1428 merged commit 71ed93c into main Aug 7, 2025
45 of 52 checks passed
@tconley1428 tconley1428 deleted the replayer_plugin branch August 7, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Worker plugin support for replayers
3 participants