Improve Nexus cancellation type test assertions #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Aug 7, 2025
bergundy
approved these changes
Aug 7, 2025
Comment on lines
+1080
to
+1084
| if o.unblockCancelCh != nil { | ||
| // Should only be non-nil in the TRY_CANCEL case. | ||
| <-o.unblockCancelCh | ||
| } | ||
| return o.workflowRunOp.Cancel(ctx, token, options) |
There was a problem hiding this comment.
Why do you need to also eventually cancel in the TRY_CANCEL case? What's the expected behavior when the workflow is eventually canceled? Do we assert anything?
There was a problem hiding this comment.
I just need to delay the cancel request. It doesn't have to eventually cancel, but immediately returning an error would just cause a NEXUS_OPERATION_CANCEL_REQUEST_FAILED event which would unblock WAIT_REQUESTED making TRY_CANCEL and WAIT_REQUESTED the same.
Quinn-With-Two-Ns
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Small improvements to Nexus cancellation types test assertions and remove sleeps to reduce flakiness.