-
Notifications
You must be signed in to change notification settings - Fork 91
Fix/mongodb auth conf #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mongodb auth conf #1741
Conversation
|
Tested with: |
|
also tested with: and use iotajson |
|
@FukayaTakashi what do you think ? You can retry with - IOTA_MONGO_AUTH_SOURCE=admin or even with IOTA_MONGO_URI in master |
fgalan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting to @FukayaTakashi feedback before merging
|
Probably overpassed by PR #1742 Let's wait for a while before closing definitively this PR. |
|
we can close this PR |
#1736
This is really a small improvement, mongoose does not need options.auth, just auth in in url, so this PR removes it for mongoose