allow use commands by simple subscriptions/notifications #1734
Conversation
|
Maybe useCmdBySubs should use a string value instead of true/false to make it more extensible? I mean:
|
AlvaroVega
changed the title
| } | ||
|
|
||
| function updateRegisterDevice(deviceObj, previousDevice, entityInfoUpdated, callback) { | ||
| // |
| apply(extractDeviceDifference, deviceObj), | ||
| createInitialEntityNgsi2Fake, | ||
| apply(combineWithNewDevice, deviceObj), | ||
| // |
| .reduce(mergeWithSameName, []); | ||
|
|
||
| if (attrs.length === 0) { | ||
| logger.debug(context, 'Subscription is not needed. Device without lazy attrs or commands'); |
There was a problem hiding this comment.
Not sure if the references to "lazy attrs" is correct here... The subscription will only cover the commands case, not lazy attributes.
| config.storeLastMeasure = config.storeLastMeasure === true; | ||
| } | ||
| if (process.env.IOTA_CMD_MODE) { | ||
| config.cmdMode = process.env.IOTA_CMD_MODE; |
There was a problem hiding this comment.
Should the new config item / env var be described in some .md file? Not sure, but I think to remember we have a document about configurations...
|
Coverage show s -0.2% decrease. Although I have seen some test has been modified to align with the new implementation, is the new logic covered by new tests? |
|
CNR entry should be added describing the changes in this PR (new fields added, basically) |
|
Still work in progress |
|
@fgalan this PR (and related PRs) is ready |
|
Clarified entity creation conditions regarding commands and attributes.
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
Issue: #1732