Skip to content

[WIP] FIX loop protection #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] FIX loop protection #3893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2bf897
FIX loop protectiong
fgalan Jul 14, 2021
5c96325
Merge branch 'master' into fix/loop-protection
fgalan Jun 11, 2024
641a854
Merge branch 'master' into fix/loop-protection
fgalan Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES_NEXT_RELEASE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Fix: wrong date values should not allowed in subscription's expires field (#4541)
- Fix: do not raise DB alarm in case of wrong GeoJSON in client request
- Fix: do not raise DB alarm in case of wrong GeoJSON in client request
- Fix: extend loop protection to any request (not only custom notifications) to cover potential update loops due to CEP integration
6 changes: 3 additions & 3 deletions src/lib/mongoBackend/MongoCommonUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3651,10 +3651,10 @@ static unsigned int updateEntity
*attributeNotExistingList += " ]";
*attributeAlreadyExistsList += " ]";

// The logic to detect notification loops is to check that the correlator in the request differs from the last one seen for the entity and,
// in addition, the request was sent due to a custom notification
// The logic to detect notification loops is to check that the correlator in the request differs from the last one seen for the entity
// (for any kind of request, not only forged by custom notification, e.g. CEP rule)
bool loopDetected = false;
if ((ngsiV2AttrsFormat == "custom") && (r.hasField(ENT_LAST_CORRELATOR)))
if (r.hasField(ENT_LAST_CORRELATOR))
{
loopDetected = (getStringFieldF(r, ENT_LAST_CORRELATOR) == correlatorRoot(fiwareCorrelator));
}
Expand Down