Rewrite BUILD_SLICE to LOAD_SLICE_CACHED when it's constant#464
Draft
tekknolagi wants to merge 2 commits into
Draft
Rewrite BUILD_SLICE to LOAD_SLICE_CACHED when it's constant#464tekknolagi wants to merge 2 commits into
tekknolagi wants to merge 2 commits into
Conversation
ab25039 to
d26ec1d
Compare
Owner
Author
|
TODO: add tests |
Owner
Author
|
An alternative idea: do this in the compiler. Unfortunately this means adding new marshaling and unmarshaling for slices and that seems more invasive. |
This saves on allocations. It's a little finicky, though, since it relies on a series of three LOAD_CONST with no EXTENDED_ARG.
d26ec1d to
1157be4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Summary
Benchmark detailsBase vs. New
CPython vs New
Base
New
CPython
|
Owner
Author
|
Better idea: python/cpython#94168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves on allocations. It's a little finicky, though, since it
relies on a series of three LOAD_CONST with no EXTENDED_ARG.