Speed up bootstrap __build_class__ a little bit#426
Open
tekknolagi wants to merge 1 commit into
Open
Conversation
a7b3533 to
d727b03
Compare
Summary
Base vs. New
CPython vs New
Base
New
CPython
|
Since we're iterating over the layouts table one by one, and the layouts table will always be at least LayoutId::kLastBuiltinId layouts long, use `Tuple::at` instead of `Runtime::layoutAtSafe`, which does a bunch of checks. This search is still linear and kind of long, though.
d727b03 to
1374a10
Compare
Summary
Base vs. New
CPython vs New
Base
New
CPython
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're iterating over the layouts table one by one, and the layouts table will always be at least LayoutId::kLastBuiltinId layouts long, use
Runtime::layoutAtinstead ofRuntime::layoutAtSafe, which does a bunch of checks. This search is still linear and kind of long, though.