Skip to content

fix : handling null pointer#692

Open
nikunjkumar05 wants to merge 1 commit intotekdi:mainfrom
nikunjkumar05:main
Open

fix : handling null pointer#692
nikunjkumar05 wants to merge 1 commit intotekdi:mainfrom
nikunjkumar05:main

Conversation

@nikunjkumar05
Copy link
Copy Markdown

@nikunjkumar05 nikunjkumar05 commented Mar 17, 2026

A small fix fieldTypeClasses.ts better solution for null handling

Summary by CodeRabbit

  • Bug Fixes
    • Fixed JSON field validation to properly reject null values, strengthening data validation integrity.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5a291684-5385-4bda-a7ae-a185ec81b1dd

📥 Commits

Reviewing files that changed from the base of the PR and between d24e956 and 99e8fff.

📒 Files selected for processing (1)
  • src/fields/fieldValidators/fieldTypeClasses.ts

Walkthrough

The JsonField.validate method in fieldTypeClasses.ts was modified to explicitly reject null values. The validation condition now includes a null check (value !== null) alongside the existing object type check, changing how null inputs are handled during JSON field validation.

Changes

Cohort / File(s) Summary
JSON Field Validation
src/fields/fieldValidators/fieldTypeClasses.ts
Modified JsonField.validate to reject null values by adding explicit null check to the type validation condition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix : handling null pointer' accurately reflects the main change: adding null validation to JsonField.validate method to properly reject null values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@sonarqubecloud
Copy link
Copy Markdown

@nikunjkumar05
Copy link
Copy Markdown
Author

@Sourav-Tekdi @Shubham4026 please review my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant