Move feature plugin package installs to Python for image mode support

.packit.yaml

@@ -123,10 +123,20 @@ _:
     tf_extra_params:
       environments:
         - tmt:
-            context:
+            context: &provision-context
               how: provision
           <<: *tmt-cloud-resources
 
+  # Image mode
+  - &image-mode
+    tf_extra_params:
+      environments:
+        - tmt:
+            context:
+              <<: *provision-context
+              image_mode: "yes"
+          <<: *tmt-cloud-resources
+
 jobs:
   # Build released bits to stable
   - <<: *copr-under-teemtee
@@ -176,6 +186,11 @@ jobs:
     identifier: provision-virtual
     tmt_plan: /plans/provision/virtual
 
+  - <<: *provision
+    <<: *image-mode
+    identifier: provision-image-mode-virtual
+    tmt_plan: /plans/provision/virtual
+
   # Test internal plugins
   - <<: *test-base
     <<: *internal

plans/provision/virtual.fmf

@@ -60,9 +60,18 @@ adjust+:
     because: Disable IPv6 in CI to avoid IPv6 connections that are disabled in CI
     when: trigger == commit
 
+  - discover+:
+        filter: 'tag:provision-virtual & tag:image-mode'
+    environment+:
+        IMAGE_MODE: "yes"
+    when: image_mode == yes
+
 /provision:
     discover+:
         test: "^/tests/provision"
+    adjust+:
+      - enabled: false
+        when: image_mode == yes
 
 /prepare:
     discover+:
@@ -77,11 +86,20 @@ adjust+:
     discover+:
         test: "^/tests/execute"
         exclude: "^/tests/execute/upgrade"
+    adjust+:
+      - enabled: false
+        when: image_mode == yes
 
 /upgrade:
     discover+:
         test: "^/tests/execute/upgrade"
+    adjust+:
+      - enabled: false
+        when: image_mode == yes
 
 /the-rest:
     discover+:
         test: "^/tests/(?!provision|prepare|execute)"
+    adjust+:
+      - enabled: false
+        when: image_mode == yes

tests/images.sh

@@ -51,6 +51,20 @@ fedora-coreos}"
 # combinations, just make sure the basic functionality works.
 TEST_VIRTUAL_IMAGES_SECONDARY="${TEST_VIRTUAL_IMAGES_SECONDARY:-fedora-42}"
 
+# Base URL for image mode qcow2s
+IMAGE_MODE_QCOW2_BASE_URL="https://artifacts.dev.testing-farm.io/images"
+
+# Image mode QCOW2 images, with mapping to compatible container image used for artifacts downloading
+declare -A IMAGE_MODE_QCOW2_CONTAINER_MAP
+IMAGE_MODE_QCOW2_CONTAINER_MAP=(
+  ["$IMAGE_MODE_QCOW2_BASE_URL/CentOS-Stream-9-image-mode-x86_64.qcow2"]="centos:stream9"
+  ["$IMAGE_MODE_QCOW2_BASE_URL/CentOS-Stream-10-image-mode-x86_64.qcow2"]="centos:stream10"
+  ["$IMAGE_MODE_QCOW2_BASE_URL/Fedora-44-image-mode-x86_64.qcow2"]="fedora:44"
+)
+
+# Set of image mode virtual images to test on.
+TEST_IMAGE_MODE_IMAGES="${TEST_IMAGE_MODE_IMAGES:-$(printf "%s\n" "${!IMAGE_MODE_QCOW2_CONTAINER_MAP[@]}")}"
+
 # A couple of "is image this?" helpers, to simplify conditions.
 function is_fedora_rawhide () {
     [[ "$1" =~ ^.*fedora/rawhide[:/].* ]] && return 0
@@ -90,6 +104,7 @@ function is_centos_stream_9 () {
 function is_centos_stream_10 () {
     [[ "$1" =~ ^.*centos/stream10[:/].* ]] && return 0
     [[ "$1" = "centos-stream-10" ]] && return 0
+    [[ "$1" =~ CentOS-Stream-10 ]] && return 0
 
     return 1
 }
@@ -130,11 +145,11 @@ function is_fedora_coreos () {
 }
 
 function is_fedora () {
-    [[ "$1" =~ ^.*fedora.* ]] && return 0 || return 1
+    [[ "${1,,}" =~ ^.*fedora.* ]] && return 0 || return 1
 }
 
 function is_centos () {
-    [[ "$1" =~ ^.*centos.* ]] && return 0 || return 1
+    [[ "${1,,}" =~ ^.*centos.* ]] && return 0 || return 1
 }
 
 function is_rhel () {
@@ -153,6 +168,10 @@ function is_ubi_8 () {
     [[ "$1" =~ ^.*ubi/8.* ]] && return 0 || return 1
 }
 
+function is_image_mode () {
+    [[ "$1" =~ image-mode ]]
+}
+
 function test_phase_prefix () {
     if [ "$PROVISION_HOW" = "local" ]; then
         echo "[$PROVISION_HOW]"

tests/prepare/feature/crb/data/plans.fmf

@@ -1,5 +1,5 @@
 provision:
-  how: container
+  how: $PROVISION_HOW
 
 execute:
   how: tmt

tests/prepare/feature/crb/main.fmf

@@ -3,3 +3,5 @@ description: Make sure enable/disable CRB works.
 tag+:
   - provision-container
   - provision-only
+  - provision-virtual
+  - image-mode

tests/prepare/feature/crb/test.sh

@@ -2,51 +2,67 @@
 . /usr/share/beakerlib/beakerlib.sh || exit 1
 . ../../../images.sh || exit 1
 
+CONTAINER_IMAGES="$TEST_IMAGE_PREFIX/centos/stream9/upstream:latest
+$TEST_IMAGE_PREFIX/ubi/8/upstream:latest
+ubi9"
+
 rlJournalStart "CRB Feature Test"
     rlPhaseStartSetup
         rlRun "PROVISION_HOW=${PROVISION_HOW:-container}"
+        rlRun "IMAGE_MODE=${IMAGE_MODE:-no}"
 
-        build_container_image "centos/stream9/upstream\:latest"
-        build_container_image "ubi/8/upstream\:latest"
-        build_container_image "fedora/latest\:latest"
+        if [ "$PROVISION_HOW" = "container" ]; then
+            build_container_image "centos/stream9/upstream\:latest"
+            build_container_image "ubi/8/upstream\:latest"
+            build_container_image "fedora/latest\:latest"
+            rlRun "IMAGES='$CONTAINER_IMAGES'"
+        elif [ "$PROVISION_HOW" = "virtual" ]; then
+            if [ "$IMAGE_MODE" = "yes" ]; then
+                rlRun "IMAGES='$TEST_IMAGE_MODE_IMAGES'"
+            else
+                rlRun "IMAGES='$TEST_VIRTUAL_IMAGES'"
+            fi
+        else
+            rlDie "Test supported only on containers or VMs"
+        fi
 
         rlRun "pushd data"
     rlPhaseEnd
 
-    images="$TEST_IMAGE_PREFIX/centos/stream9/upstream:latest $TEST_IMAGE_PREFIX/ubi/8/upstream:latest ubi9"
-
     # CRB
-    for image in $images; do
-        # Run the '/crb/enabled' plan, overriding the provision image.
-        # The plan itself contains the check (dnf repolist enabled | grep ...).
-        # Expecting tmt run to succeed (exit code 0) as the check should pass.
-        rlPhaseStartTest "Test /crb/enabled on $image"
-            rlRun "tmt run --all provision --how container --image $image plan --name /crb/enabled" 0 "Run /crb/enabled plan for $image"
-        rlPhaseEnd
-
-        # Run the '/crb/disabled' plan, overriding the provision image.
-        # The plan itself contains the checks (! dnf repolist enabled ... && dnf repolist disabled ...).
-        # Expecting tmt run to succeed (exit code 0) as the checks should pass.
-        rlPhaseStartTest "Test /crb/disabled on $image"
-            rlRun "tmt run --all provision --how container --image $image plan --name /crb/disabled" 0 "Run /crb/disabled plan for $image"
-        rlPhaseEnd
-
-        # Run the '/crb_package' only on c9s
-        if is_centos_stream_9 "$image"; then
-            rlPhaseStartTest "Test /crb/crb_package on $image"
-                # This plan enables CRB and tries to install a package from it.
-                rlRun "tmt run --all provision --how container --image $image prepare execute plan --name /crb/crb_package" 0 "Run /crb/crb_package plan for $image"
+    while IFS= read -r image; do
+        if is_fedora "$image"; then
+            # Test Fedora for the warning message
+            rlPhaseStartTest "Test warning on $image"
+                # Run a CRB plan (just provision, prepare and finish) on fedora and verify the warning is shown
+                # We expect the tmt run to succeed (exit code 0) because it's a warning, not an error.
+                rlRun -s "tmt run provision --how $PROVISION_HOW --image $image prepare finish plan --name /crb/enabled" 0 "Run plan on fedora and capture output"
+                rlAssertGrep "CRB prepare feature is supported on RHEL/CentOS-Stream 8, 9 or 10." $rlRun_LOG
+            rlPhaseEnd
+        else
+            # Run the '/crb/enabled' plan, overriding the provision image.
+            # The plan itself contains the check (dnf repolist enabled | grep ...).
+            # Expecting tmt run to succeed (exit code 0) as the check should pass.
+            rlPhaseStartTest "Test /crb/enabled on $image"
+                rlRun "tmt run --all provision --how $PROVISION_HOW --image $image plan --name /crb/enabled" 0 "Run /crb/enabled plan for $image"
             rlPhaseEnd
+
+            # Run the '/crb/disabled' plan, overriding the provision image.
+            # The plan itself contains the checks (! dnf repolist enabled ... && dnf repolist disabled ...).
+            # Expecting tmt run to succeed (exit code 0) as the checks should pass.
+            rlPhaseStartTest "Test /crb/disabled on $image"
+                rlRun "tmt run --all provision --how $PROVISION_HOW --image $image plan --name /crb/disabled" 0 "Run /crb/disabled plan for $image"
+            rlPhaseEnd
+
+            # Run the '/crb_package' only on c9s
+            if is_centos_stream_9 "$image"; then
+                rlPhaseStartTest "Test /crb/crb_package on $image"
+                    # This plan enables CRB and tries to install a package from it.
+                    rlRun "tmt run --all provision --how $PROVISION_HOW --image $image prepare execute plan --name /crb/crb_package" 0 "Run /crb/crb_package plan for $image"
+                rlPhaseEnd
+            fi
         fi
-    done
-
-    # Test Fedora for the warning message
-    rlPhaseStartTest "Test warning on fedora:latest"
-        # Run a CRB plan (just provision, prepare and finish) on fedora and verify the warning is shown
-        # We expect the tmt run to succeed (exit code 0) because it's a warning, not an error.
-        rlRun -s "tmt run provision --how container --image $TEST_IMAGE_PREFIX/fedora/latest:latest prepare finish plan --name /crb/enabled" 0 "Run plan on fedora and capture output"
-        rlAssertGrep "CRB prepare feature is supported on RHEL/CentOS-Stream 8, 9 or 10." $rlRun_LOG
-    rlPhaseEnd
+    done <<< "$IMAGES"
 
     rlPhaseStartCleanup
         rlRun "popd"

tests/prepare/feature/epel/main.fmf

@@ -3,3 +3,6 @@ description:
     Make sure enable/disable EPEL works.
 tag+:
   - provision-container
+  - provision-only
+  - provision-virtual
+  - image-mode