a tangible use case to detect circular dependency in package managers#4779
Closed
AthreyVinay wants to merge 1 commit intomainfrom
Closed
a tangible use case to detect circular dependency in package managers#4779AthreyVinay wants to merge 1 commit intomainfrom
AthreyVinay wants to merge 1 commit intomainfrom
Conversation
AthreyVinay
added
the
ci | full test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| escape_installables, | ||
| provides_package_manager, | ||
| ) | ||
| from tmt.package_managers.dnf import Dnf5 |
Contributor
There was a problem hiding this comment.
Remove this top-level import. It introduces a circular dependency between tmt.package_managers.rpm_ostree and tmt.package_managers.dnf during plugin discovery, as both modules are part of the same namespace and use the plugin registry. The import should remain local to the enable_copr method to avoid initialization issues.
Member
Author
There was a problem hiding this comment.
Thats the whole point of this - test if this works or not :D
Member
Author
|
Closing as this does not seem to be an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
investigating #4746