Conversation
happz
added
code | no functional change
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
LecrisUT
reviewed
Mar 24, 2026
LecrisUT
reviewed
Mar 26, 2026
LecrisUT
approved these changes
Mar 26, 2026
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
LecrisUT
reviewed
Mar 27, 2026
Contributor
Author
|
Tests are failing because of #4731 (comment) - once the dust settles on logging format, I will fix the tests. |
LecrisUT
approved these changes
Mar 30, 2026
tcornell-bus
approved these changes
Mar 30, 2026
Adding concept of ordering to queue tasks. Most of the time, tasks will inherit their order from phases they represent. This will allow reordering of queue after adding new tasks while the queue is already running - today, the queue is sorted at the beginning, because steps already add tasks in the order of phases they represent. Related to #4726.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding concept of ordering to queue tasks. Most of the time, tasks will inherit their order from phases they represent. This will allow reordering of queue after adding new tasks while the queue is already running - today, the queue is sorted at the beginning, because steps already add tasks in the order of phases they represent.
Related to #4726.
Pull Request Checklist