-
Notifications
You must be signed in to change notification settings - Fork 165
Improve test coverage for prepare plugins in image mode
#4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thrix
wants to merge
15
commits into
main
Choose a base branch
from
issue-4606
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b80498f
Fixes #4606
thrix 3ecb058
Addressed next round of review comments
thrix de6adeb
Move the is_image mode test next to is_ostree
thrix aca65f2
Use for to iterate over a space delimited string
thrix 6fec70c
Revert "Use for to iterate over a space delimited string"
thrix 5141f05
The images should be newline separated
thrix fa47fdb
Update .packit.yaml
thrix 5dfbb38
Fix some tests
thrix f6aecda
fix tests
thrix 57bc82b
Address a few review comments
thrix 542b3ae
Address review comments, improve prepare/shell test
thrix b2bfbea
Fix tests
thrix f90a863
Fix prepare shell tests
thrix 64bdd14
More anchors in packit.yaml, do not run irrelevants plans in image mode
thrix 3dfe7b4
Fix shell tests
thrix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| summary: Verify installed packages persist after reboot | ||
| description: | | ||
| Install packages and verify they survive a reboot. | ||
| This is critical for image mode where changes are applied | ||
| via Containerfile rebuild and bootc switch. | ||
|
|
||
| prepare: | ||
| - how: install | ||
| package: | ||
| - tree | ||
| - diffutils | ||
|
|
||
| execute: | ||
| how: tmt | ||
| script: | | ||
| tree --version | ||
| diff --version | ||
| if [ "$TMT_REBOOT_COUNT" == "0" ]; then | ||
| tmt-reboot | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.