Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This PR enables ruamel.yaml.clib by default by adding it as a dependency and setting the default YAML type to 'safe'. A suggestion is provided for tmt/utils/__init__.py to improve conciseness. Add a release note for this performance improvement.
Member
Author
|
/packit test |
happz
reviewed
Mar 23, 2026
fpokryvk
added a commit
to NetworkManager/NetworkManager-ci
that referenced
this pull request
Mar 26, 2026
Assisted-by: Claude Opus 4.6
fpokryvk
added a commit
to NetworkManager/NetworkManager-ci
that referenced
this pull request
Mar 26, 2026
Assisted-by: Claude Opus 4.6
fpokryvk
added a commit
to NetworkManager/NetworkManager-ci
that referenced
this pull request
Mar 26, 2026
Assisted-by: Claude Opus 4.6
fpokryvk
added a commit
to NetworkManager/NetworkManager-ci
that referenced
this pull request
Mar 26, 2026
Assisted-by: Claude Opus 4.6
91aa13c to
99b6d3f
Compare
Member
Author
|
Blocked by #4338 |
This was referenced Apr 9, 2026
happz
reviewed
Apr 14, 2026
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
0c764fc to
99753b2
Compare
thrix
reviewed
Apr 15, 2026
happz
approved these changes
Apr 15, 2026
psss
reviewed
Apr 15, 2026
Member
There was a problem hiding this comment.
Looks good, just one question and one thought: There are a couple more places where tmt is storing modified fmf files to disk:
tmt linktmt test idtmt test export --nitratetmt test export --polarion
But seems all those cases are actually using the fmf context manager approach:
with tmt_object.node as data:
data["link"] = [link_data]Would be good to fix on the fmf side as well. Filed here:
psss
approved these changes
Apr 15, 2026
vaibhavdaren
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the only thing we need to do to enable this is to pull in this dependency and switch to using
safetype by default. This would be a better apple-to-apple comparison with #4486 since that one uses a C library for handling json.Note that the clib does not respect
.indentformatting hintsReference:
yaml.indenthttps://yaml.dev/doc/ruamel.yaml/detailPull Request Checklist
Related to #4406