Task #141211 chore: Order View for Vendor in frontend#30
Task #141211 chore: Order View for Vendor in frontend#30amit4106udale wants to merge 1 commit intotechjoomla:release-1.4.4from
Conversation
|
The inspection completed: 7 new issues, 2 updated code elements |
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| public function validateVendor($userId, $client) |
There was a problem hiding this comment.
@amit4106udale the function name needs to be updated as per the functionality of the method.
The function seems to be checking if a user is already a vendor and if he is not then adding him as a vendor.
What exactly we are validating in this function?
There was a problem hiding this comment.
@ankush-maherwal - We are checking the user is a vendor or not. If the user is not a vendor then make him. if he is a vendor the returning the id as it is. Discussed this with @twsvaishali @thite-amol
There was a problem hiding this comment.
@thite-amol @twsvaishali @amit4106udale Seems the function is wrongly named....validateVendor sounds as if we are performing some kind of validation for the vendor (Creating the vendor should not be the part of this function). To check if a user is a vendor for some client we already have a function named "checkVendor"
3 participants
No description provided.