[REFACTOR/#402] 유빈 뷰 / 리팩토링 #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledeggg
approved these changes
Aug 29, 2025
Member
boiledeggg
left a comment
boiledeggg
left a comment
There was a problem hiding this comment.
너무 좋습니다! 따따따봉👍
오랜만에 터닝에 리뷰다니까 좋네ㅋㅎ
| @Composable | ||
| fun ProfileWithPlusButton( | ||
| profileImage: String, | ||
| onClick: (Boolean) -> Unit, |
Member
There was a problem hiding this comment.
이 컴포넌트를 사용하는 곳들에서 람다 파라미터로 주어지는 Boolean 값을 사용하지 않는 것 같던데 확인 한번 부탁드려요~
사용되지 않는 파라미터는 없애는게 좋을 것 같습니다!
Member
Author
There was a problem hiding this comment.
예리하시군요!! 저도 코드를 안 본지 오래돼서... ㅎㅎ 불린 값을 사용 안 하고 있을 거라 생각하고 찾아봤는데, 여기서 true로 넘겨준 값을 각 스크린의 뷰모델로 넘겨서 바텀시트의 가시 여부를 결정하고 있더라구요! 그래서 이대로 둬도 괜찮을 것 같아요:)
확인 감사합니당👍
Comment on lines
282
to
285
| Image( | ||
| painter = painterResource(R.drawable.ic_my_page_go_detail), | ||
| contentDescription = "go detail" | ||
| ) |
Member
There was a problem hiding this comment.
여기에 painter를 인자로 받는 Image를 사용하신 이유가 있나요?
Member
Author
There was a problem hiding this comment.
imageVector를 사용하는 방법도 있다는 말씀이시죠?!
사실.. 이전 코드들이 painter를 사용하고 있어서 그대로 사용했습니다 ..ㅎㅎ 수정해놓을게요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers