-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat(map): simplify search UX/UI #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
785e71e
refactor(map): make drawer gesture controller factory reusable
escapedcat 9bf8349
feat(map): add nearby pill count formatter
escapedcat 64984bf
feat(i18n): add single-input search keys
escapedcat 2b5266d
feat(map): single search input with nearby count pill, drop floating …
escapedcat 4bd27dd
feat(map): filtered nearby tab count and search-worldwide empty state
escapedcat 8d3a125
feat(map): mobile search bottom sheet with drawer-style snap points
escapedcat 2326c09
fix(map): harden search sheet gestures, a11y, e2e, and translations a…
escapedcat 443edf4
feat(map): drag the search sheet from the input and filter rows
escapedcat 1a3bf65
fix(map): slim search sheet peek to 84px with adaptive safe-area
escapedcat 894ca9b
fix(map): address review feedback on search sheet
escapedcat 2e36dee
feat(map): floating search peek card with drag handle
escapedcat 72aef85
feat(map): single search input — drop Worldwide/Nearby toggle
escapedcat 7644fe3
chore(i18n): remove dead toggle/CTA keys and analytics events
escapedcat 217f33d
feat(map): compact attribution + float search above the bottom chrome
escapedcat 5c43955
fix(map): populate nearby count on first load, collapse attribution
escapedcat 42fd7fe
test(map): update panel e2e for the single-input search model
escapedcat 552b591
feat(map): show nearby count inside the open desktop panel
escapedcat e728acd
fix(map): only compact the attribution on mobile
escapedcat 1ada5db
fix(map): harden search + drop dead formatNearbyCount
escapedcat e8be146
feat(map): shared CollapseButton caret with round background
escapedcat 113b316
test(map): assert nearby count shows in the open desktop panel
escapedcat d0b0fe1
fix(map): address CodeRabbit review
escapedcat 4f6d8e7
fix(map): address Copilot review
escapedcat d303044
docs(map): correct stale SEARCH_SHEET_PEEK_HEIGHT comment
escapedcat 553d26c
fix(map): guard nearby status-row zoom-in link while list loads
escapedcat 7799621
refactor(map): anchor the search sheet to the bottom edge
escapedcat 20b196d
fix(map): guard areas without a tags object in getCommunitiesAtCoordi…
escapedcat 434115a
fix(map): only preventDefault cancelable touchmove in collapse drag
escapedcat 1b00316
refactor(map): drop merchant peek swipe hint and tighten peek height
escapedcat a0ce6cc
refactor(map): remove cluster hover-hull green polygon
escapedcat c426f8e
fix(map): address Copilot review on nearby count cap
escapedcat 0031287
docs(map): drop Google Maps references from code comments
escapedcat 079d68a
test(map): detect mobile drawer via dialog role not swipe-hint text
escapedcat c5ff53a
fix(map): keep the search peek clear of the bottom gesture bar
escapedcat fa8500e
refactor(map): drive bottom-chrome lift from the peek-height const
escapedcat 776082c
fix(map): search peek stuck at full height after select then back
escapedcat 15ed3f6
fix(map): guard search error path and trim the query before fetch
escapedcat e7418e2
fix(map): close the list when the merchant drawer opens on mobile
escapedcat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <script lang="ts"> | ||
| import Icon from "$components/Icon.svelte"; | ||
|
|
||
| // Collapse caret used by the bottom drawers/sheets (merchant drawer, search | ||
| // sheet). A round light background makes it read as a button. pointerdown is | ||
| // stopped so pressing it never starts a sheet drag. | ||
| export let onClick: () => void; | ||
| export let ariaLabel: string; | ||
| let className = ""; | ||
|
|
||
| export { className as class }; | ||
| </script> | ||
|
|
||
| <button | ||
| type="button" | ||
| on:pointerdown|stopPropagation | ||
| on:click={onClick} | ||
| class="grid h-8 w-8 touch-auto place-items-center rounded-full bg-gray-100 text-primary transition-colors hover:bg-gray-200 dark:bg-white/10 dark:text-white dark:hover:bg-white/20 {className}" | ||
| aria-label={ariaLabel} | ||
| {...$$restProps} | ||
| > | ||
| <Icon w="20" h="20" icon="keyboard_arrow_down" type="material" /> | ||
| </button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.