Show warning icon for apps with dangerous filesystem permissions (fixes #163) #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes tchx84#163) - Detect dangerous filesystem permissions (`host` or `home`) in app list - Pass this info to FlatsealApplicationRow - Display warning icon and tooltip for affected apps - Improves user awareness of security risks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning icon to the application list for apps that have dangerous filesystem permissions (host or home). This helps users identify apps with potentially risky access to the host filesystem.
Changes:
Detects dangerous filesystem permissions in window.js.
Passes this information to FlatsealApplicationRow.
Updates FlatsealApplicationRow to display a warning icon and tooltip when dangerous permissions are present.
Motivation: Addresses issue #163 by making it easier for users to spot apps with elevated filesystem access, improving security awareness.
Testing:
Verified that apps with filesystem=host or filesystem=home show the warning icon.
Apps without these permissions are unaffected.
Let me know if any changes are needed!